Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2015571: [4.9] add kube_persistentvolumeclaim_labels and kube_persistentvolume_labels #1457

Merged
merged 1 commit into from Oct 28, 2021

Conversation

arajkumar
Copy link
Contributor

Cherry pick #1424

Signed-off-by: Michael Skarbek mskarbek@redhat.com

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

…tvolume_labels

Signed-off-by: Michael Skarbek <mskarbek@redhat.com>
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Oct 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2021

@arajkumar: This pull request references Bugzilla bug 2012915, which is invalid:

  • expected the bug to target the "4.9.z" release, but it targets "4.10.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
  • expected Bugzilla bug 2012915 to depend on a bug targeting a release in 4.10.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2012915: add kube_persistentvolumeclaim_labels and kube_persistentvolume_labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 28, 2021
@arajkumar
Copy link
Contributor Author

/retitle Bug 2015571: [4.9] add kube_persistentvolumeclaim_labels and kube_persistentvolume_labels

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2021
@openshift-ci openshift-ci bot changed the title Bug 2012915: add kube_persistentvolumeclaim_labels and kube_persistentvolume_labels Bug 2015571: [4.9] add kube_persistentvolumeclaim_labels and kube_persistentvolume_labels Oct 28, 2021
@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2021

@arajkumar: This pull request references Bugzilla bug 2015571, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2012915 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2012915 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

Bug 2015571: [4.9] add kube_persistentvolumeclaim_labels and kube_persistentvolume_labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 28, 2021
@openshift-ci openshift-ci bot requested a review from juzhao October 28, 2021 07:46
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2021

@arajkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions baf3d2d link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@arajkumar
Copy link
Contributor Author

/skip

@arajkumar
Copy link
Contributor Author

Hello @team-monitoring-backport-approvers, Please approve this back port. Thanks!

@juzhao
Copy link

juzhao commented Oct 28, 2021

tested with the PR
launch 4.9.0-0.nightly-2021-10-27-202207,openshift/cluster-monitoring-operator#1457, could see the PV/PVC labels now, se from https://bugzilla.redhat.com/show_bug.cgi?id=2015571#c2
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 28, 2021
@juzhao
Copy link

juzhao commented Oct 28, 2021

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 28, 2021
@simonpasquier
Copy link
Contributor

/label backport-risk-assessed
/lgtm

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 28, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2021
@openshift-merge-robot openshift-merge-robot merged commit fe86fa9 into openshift:release-4.9 Oct 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2021

@arajkumar: All pull requests linked via external trackers have merged:

Bugzilla bug 2015571 has been moved to the MODIFIED state.

In response to this:

Bug 2015571: [4.9] add kube_persistentvolumeclaim_labels and kube_persistentvolume_labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arajkumar, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [arajkumar,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juzhao
Copy link

juzhao commented Oct 29, 2021

/lgtm

@arajkumar
Copy link
Contributor Author

/cherry-pick release-4.8

@openshift-cherrypick-robot

@arajkumar: #1457 failed to apply on top of branch "release-4.8":

Applying: Bug 2012915: add kube_persistentvolumeclaim_labels and kube_persistentvolume_labels
Using index info to reconstruct a base tree...
M	assets/kube-state-metrics/deployment.yaml
A	jsonnet/components/kube-state-metrics.libsonnet
Falling back to patching base and 3-way merge...
Auto-merging jsonnet/kube-state-metrics.libsonnet
CONFLICT (content): Merge conflict in jsonnet/kube-state-metrics.libsonnet
Auto-merging assets/kube-state-metrics/deployment.yaml
CONFLICT (content): Merge conflict in assets/kube-state-metrics/deployment.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 2012915: add kube_persistentvolumeclaim_labels and kube_persistentvolume_labels
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants