New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TestUserWorkloadMonitoringAlerting for Prometheus Operator v0.52 #1479
Fix TestUserWorkloadMonitoringAlerting for Prometheus Operator v0.52 #1479
Conversation
/retest-required |
/test e2e-aws-single-node |
That assertion is testing an implementation detail of Prometheus Operator, there's no guarantee that the file name won't change in the future. Do we still need to have this test? |
I think this test is for verifying the rule files are created correctly. |
I agree with @fpetkovski: the test shouldn't check the filename. |
…s a postfix to avoid name collision
0b1fbeb
to
de3680b
Compare
Test updated, no checks on file name now :) |
/test e2e-aws-single-node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/label qe-approved this is only updating the e2e tests, no functional change. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raptorsun, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@raptorsun: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/skip |
Prometheus Operator version 0.52 has a new feature to append a postfix to the rule file name to avoid name collision. This breaks the E2E test TestUserWorkloadMonitoringAlerting which assumes rule file without this postfix.
This PR update that test so it can pass after upgrading Prometheus Operator to version 0.52.
rule file name before 0.52:
/etc/prometheus/rules/prometheus-user-workload-rulefiles-0/user-workload-test-prometheus-example-rule-leaf.yaml
rule file name after 0.52:
/etc/prometheus/rules/prometheus-user-workload-rulefiles-0/user-workload-test-prometheus-example-rule-leaf-f4c6359f-9510-4c1d-9b44-5aa014b3aacd.yaml