New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client certificate and key to service monitor #1738
Add client certificate and key to service monitor #1738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, the files under assets/
are generated by jsonnet, so you'll have to change the respecitve files in jsonnet/components
and run make generate
.
But please note that some service monitors weren't changed in the original PR adding mTLS auth for metric scraping: #1282.
I'd expect these issues persist.
834ab70
to
dc6128e
Compare
@xueqzhan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/skip |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: simonpasquier, xueqzhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label docs-approved |
/label qe-approved |
Description of the change:
Add client certificate and key to service monitor so that prometheus scraper does not depend on API server availability.
Motivation for the change:
https://github.com/deads2k/openshift-enhancements/blob/master/enhancements/monitoring/client-cert-scraping.md