-
Notifications
You must be signed in to change notification settings - Fork 381
OCPBUGS-63502: Fix service-CA certificate rotation not triggering pod restarts #2726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OCPBUGS-63502: Fix service-CA certificate rotation not triggering pod restarts #2726
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielmellado The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When service-CA rotates certificates, the cluster-monitoring-operator wasn't watching service-CA generated secrets, causing pods to continue using expired certificates until manually restarted. This change adds detect changes happeing for service-CA secrets in monitoring namespaces (secrets ending with -tls or -cert) and triggers reconciliation when they change, which triggers pod restarts and certificate pickup. Fixes the issue where EUS clusters running 3+ years without upgrades require manual intervention after service-CA rotation. Signed-off-by: Daniel Mellado <dmellado@fedoraproject.org>
30ab202 to
afd86af
Compare
|
/retest-required |
|
@danielmellado: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retitle OCPBUGS-63502: Fix service-CA certificate rotation not triggering pod restarts |
|
@danielmellado: This pull request references Jira Issue OCPBUGS-63502, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@danielmellado: This pull request references Jira Issue OCPBUGS-63502, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
When service-CA rotates certificates, the cluster-monitoring-operator
wasn't watching service-CA generated secrets, causing pods to continue
using expired certificates until manually restarted.
This change adds detect changes happeing for service-CA secrets in
monitoring namespaces (secrets ending with -tls or -cert) and triggers
reconciliation when they change, which triggers pod restarts and
certificate pickup.
Fixes the issue where EUS clusters running 3+ years without upgrades
require manual intervention after service-CA rotation.