Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serviceMonitorKubeScheduler/serviceMonitorKubeControllerManager: enable TLS #316

Merged
merged 2 commits into from Apr 17, 2019

Conversation

@s-urbaniak
Copy link
Contributor

s-urbaniak commented Apr 10, 2019

In accordance to
openshift/cluster-kube-scheduler-operator#88 and
openshift/cluster-kube-controller-manager-operator#207
we can now enable TLS for the kube scheduler as well the controller
manager.

This combines the two patches in one again.

@s-urbaniak

This comment has been minimized.

Copy link
Contributor Author

s-urbaniak commented Apr 10, 2019

@s-urbaniak

This comment has been minimized.

Copy link
Contributor Author

s-urbaniak commented Apr 10, 2019

rechecked on a local cluster, locally port-forwarding the controller-manager/scheduler secure ports and using a local curl, everything works nicely, but pods on the cluster cannot reach the endpoints.

image

@s-urbaniak

This comment has been minimized.

Copy link
Contributor Author

s-urbaniak commented Apr 10, 2019

It turns out, VPC security settings need an update: openshift/installer#1576

s-urbaniak added 2 commits Apr 5, 2019
@s-urbaniak s-urbaniak force-pushed the s-urbaniak:secure-ctrl-sched branch from 0ad8c37 to f136be5 Apr 12, 2019
@s-urbaniak

This comment has been minimized.

Copy link
Contributor Author

s-urbaniak commented Apr 12, 2019

@brancz PTAL

@brancz

This comment has been minimized.

Copy link
Contributor

brancz commented Apr 12, 2019

/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Apr 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@s-urbaniak

This comment has been minimized.

Copy link
Contributor Author

s-urbaniak commented Apr 12, 2019

verified this patch in conjunction with openshift/installer#1576 locally

image

@s-urbaniak

This comment has been minimized.

Copy link
Contributor Author

s-urbaniak commented Apr 12, 2019

/test e2e-aws

1 similar comment
@s-urbaniak

This comment has been minimized.

Copy link
Contributor Author

s-urbaniak commented Apr 12, 2019

/test e2e-aws

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

15 similar comments
@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@paulfantom

This comment has been minimized.

Copy link
Member

paulfantom commented Apr 16, 2019

/retest

@paulfantom

This comment has been minimized.

Copy link
Member

paulfantom commented Apr 16, 2019

/refresh
/retest

@paulfantom

This comment has been minimized.

Copy link
Member

paulfantom commented Apr 16, 2019

/retest

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Apr 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@paulfantom

This comment has been minimized.

Copy link
Member

paulfantom commented Apr 17, 2019

/retest

5 similar comments
@paulfantom

This comment has been minimized.

Copy link
Member

paulfantom commented Apr 17, 2019

/retest

@brancz

This comment has been minimized.

Copy link
Contributor

brancz commented Apr 17, 2019

/retest

@paulfantom

This comment has been minimized.

Copy link
Member

paulfantom commented Apr 17, 2019

/retest

@s-urbaniak

This comment has been minimized.

Copy link
Contributor Author

s-urbaniak commented Apr 17, 2019

/retest

@paulfantom

This comment has been minimized.

Copy link
Member

paulfantom commented Apr 17, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 724ca54 into openshift:master Apr 17, 2019
6 checks passed
6 checks passed
ci/prow/e2e-aws Job succeeded.
Details
ci/prow/e2e-aws-operator Job succeeded.
Details
ci/prow/images Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tide In merge pool.
Details
@s-urbaniak s-urbaniak deleted the s-urbaniak:secure-ctrl-sched branch Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.