Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2009078: Remove NetworkPodsCrashLooping alert for ovn-kubernetes #1212

Merged
merged 1 commit into from Nov 4, 2021
Merged

Bug 2009078: Remove NetworkPodsCrashLooping alert for ovn-kubernetes #1212

merged 1 commit into from Nov 4, 2021

Conversation

npinaeva
Copy link
Member

@npinaeva npinaeva commented Nov 2, 2021 •
edited

use existing KubePodCrashLooping (https://github.com/openshift/cluster-monitoring-operator/blob/master/assets/control-plane/prometheus-rule.yaml#L15) alert from cluster-network-operator instead.
NetworkPodsCrashLooping not only duplicates existing KubePodCrashLooping alert, but actually alerts on restarts instead of crashlooping events

To verify this behaviour one can deploy creashlooping pod in ovn-kubernetes namespace and check prometheus alerts

Signed-off-by: Nadia Pinaeva npinaeva@redhat.com

@npinaeva
Remove NetworkPodsCrashLooping alert for ovn-kubernetes, use
1d68d27 
existing KubePodCrashLooping alert from cluster-network-operator
instead.

Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
@openshift-ci openshift-ci bot requested review from trozet and tssurya November 2, 2021 10:16
@npinaeva
Copy link
Member Author

npinaeva commented Nov 2, 2021

/assign @wking

@npinaeva npinaeva changed the title Remove NetworkPodsCrashLooping alert for ovn-kubernetes Bug 2009078: Remove NetworkPodsCrashLooping alert for ovn-kubernetes Nov 2, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2021

@npinaeva: This pull request references Bugzilla bug 2009078, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2009078: Remove NetworkPodsCrashLooping alert for ovn-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@npinaeva
Copy link
Member Author

npinaeva commented Nov 2, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Nov 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2021

@npinaeva: This pull request references Bugzilla bug 2009078, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 2, 2021
@jluhrsen
Copy link
Contributor

jluhrsen commented Nov 2, 2021

/retest

wking
wking approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an approver, but:

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2021 •
edited

@npinaeva: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn 1d68d27 link false /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@npinaeva
Copy link
Member Author

npinaeva commented Nov 4, 2021

/retest-required

trozet
trozet approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npinaeva, trozet, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2021
@openshift-merge-robot openshift-merge-robot merged commit 2789553 into openshift:master Nov 4, 2021
20 of 21 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2021

@npinaeva: All pull requests linked via external trackers have merged:

Bugzilla bug 2009078 has been moved to the MODIFIED state.

In response to this:

Bug 2009078: Remove NetworkPodsCrashLooping alert for ovn-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking approved these changes

@trozet trozet trozet approved these changes

@tssurya tssurya Awaiting requested review from tssurya

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@wking wking

@trozet trozet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@npinaeva @jluhrsen @wking @trozet @openshift-merge-robot