Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2022144: sbdb and nbdb containers leave pid around if they restarted or crashed #1256

Merged
merged 1 commit into from Dec 16, 2021

Conversation

msherif1234
Copy link
Contributor

This PR remove pidfile on postStart hook to avoid run_n/sb_ovsdb from an early return.

Signed-off-by: Mohamed Mahmoud mmahmoud@redhat.com

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

@msherif1234: This pull request references Bugzilla bug 2022144, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

Bug 2022144: sbdb and nbdb containers leave pid around if they restarted or crashed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…ted or crashed

This PR remove pidfile on postStart hook to avoid run_n/sb_ovsdb from an early return.

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

@msherif1234: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-upgrade e6a5294 link false /test e2e-gcp-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 e6a5294 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec e6a5294 link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-aws-ovn-windows e6a5294 link true /test e2e-aws-ovn-windows
ci/prow/e2e-vsphere-ovn e6a5294 link false /test e2e-vsphere-ovn
ci/prow/e2e-vsphere-windows e6a5294 link false /test e2e-vsphere-windows
ci/prow/e2e-azure-ovn e6a5294 link false /test e2e-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@msherif1234
Copy link
Contributor Author

/retest

Copy link
Contributor

@flavio-fernandes flavio-fernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short of the long commit summary...
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2021
@trozet
Copy link
Contributor

trozet commented Dec 16, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavio-fernandes, msherif1234, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@trozet
Copy link
Contributor

trozet commented Dec 16, 2021

/override ci/prow/e2e-aws-sdn-multi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2021

@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-aws-sdn-multi

In response to this:

/override ci/prow/e2e-aws-sdn-multi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@trozet
Copy link
Contributor

trozet commented Dec 16, 2021

/override ci/prow/e2e-aws-sdn-multi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2021

@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-aws-sdn-multi

In response to this:

/override ci/prow/e2e-aws-sdn-multi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 8f137c9 into openshift:master Dec 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2021

@msherif1234: All pull requests linked via external trackers have merged:

Bugzilla bug 2022144 has been moved to the MODIFIED state.

In response to this:

Bug 2022144: sbdb and nbdb containers leave pid around if they restarted or crashed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Member

dcbw commented Jan 26, 2022

/cherry-pick release-4.9

@openshift-cherrypick-robot

@dcbw: new pull request created: #1291

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rbbratta added a commit to rbbratta/verification-tests that referenced this pull request Apr 11, 2022
BZ 2022144: `sbdb` will CrashLoopBackOff when there is a stale PID file.

Regular `pkill` will send `SIGTERM` which allows the container to cleanup
the pid file somehow in one of the hooks.  To simulate a crash we need
to kill without chance of cleanup and leave a stale PID.

Now that openshift/cluster-network-operator#1256
is merged we can test without breaking the cluster

s/openfolw/openflow/
rbbratta added a commit to rbbratta/verification-tests that referenced this pull request Apr 11, 2022
BZ 2022144: `sbdb` will CrashLoopBackOff when there is a stale PID file.

Regular `pkill` will send `SIGTERM` which allows the container to cleanup
the pid file somehow in one of the hooks.  To simulate a crash we need
to kill without chance of cleanup and leave a stale PID.

Now that openshift/cluster-network-operator#1256
is merged we can test without breaking the cluster

s/openfolw/openflow/
openshift-merge-robot pushed a commit to openshift/verification-tests that referenced this pull request Apr 12, 2022
BZ 2022144: `sbdb` will CrashLoopBackOff when there is a stale PID file.

Regular `pkill` will send `SIGTERM` which allows the container to cleanup
the pid file somehow in one of the hooks.  To simulate a crash we need
to kill without chance of cleanup and leave a stale PID.

Now that openshift/cluster-network-operator#1256
is merged we can test without breaking the cluster

s/openfolw/openflow/
sunzhaohua2 pushed a commit to sunzhaohua2/verification-tests that referenced this pull request Jun 26, 2023
BZ 2022144: `sbdb` will CrashLoopBackOff when there is a stale PID file.

Regular `pkill` will send `SIGTERM` which allows the container to cleanup
the pid file somehow in one of the hooks.  To simulate a crash we need
to kill without chance of cleanup and leave a stale PID.

Now that openshift/cluster-network-operator#1256
is merged we can test without breaking the cluster

s/openfolw/openflow/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants