New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2022144: sbdb and nbdb containers leave pid around if they restarted or crashed #1256
Bug 2022144: sbdb and nbdb containers leave pid around if they restarted or crashed #1256
Conversation
@msherif1234: This pull request references Bugzilla bug 2022144, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ted or crashed This PR remove pidfile on postStart hook to avoid run_n/sb_ovsdb from an early return. Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
430717c
to
e6a5294
Compare
@msherif1234: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Short of the long commit summary...
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flavio-fernandes, msherif1234, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/override ci/prow/e2e-aws-sdn-multi |
@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-aws-sdn-multi In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/override ci/prow/e2e-aws-sdn-multi |
@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-aws-sdn-multi In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@msherif1234: All pull requests linked via external trackers have merged: Bugzilla bug 2022144 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.9 |
@dcbw: new pull request created: #1291 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
BZ 2022144: `sbdb` will CrashLoopBackOff when there is a stale PID file. Regular `pkill` will send `SIGTERM` which allows the container to cleanup the pid file somehow in one of the hooks. To simulate a crash we need to kill without chance of cleanup and leave a stale PID. Now that openshift/cluster-network-operator#1256 is merged we can test without breaking the cluster s/openfolw/openflow/
BZ 2022144: `sbdb` will CrashLoopBackOff when there is a stale PID file. Regular `pkill` will send `SIGTERM` which allows the container to cleanup the pid file somehow in one of the hooks. To simulate a crash we need to kill without chance of cleanup and leave a stale PID. Now that openshift/cluster-network-operator#1256 is merged we can test without breaking the cluster s/openfolw/openflow/
BZ 2022144: `sbdb` will CrashLoopBackOff when there is a stale PID file. Regular `pkill` will send `SIGTERM` which allows the container to cleanup the pid file somehow in one of the hooks. To simulate a crash we need to kill without chance of cleanup and leave a stale PID. Now that openshift/cluster-network-operator#1256 is merged we can test without breaking the cluster s/openfolw/openflow/
BZ 2022144: `sbdb` will CrashLoopBackOff when there is a stale PID file. Regular `pkill` will send `SIGTERM` which allows the container to cleanup the pid file somehow in one of the hooks. To simulate a crash we need to kill without chance of cleanup and leave a stale PID. Now that openshift/cluster-network-operator#1256 is merged we can test without breaking the cluster s/openfolw/openflow/
This PR remove pidfile on postStart hook to avoid run_n/sb_ovsdb from an early return.
Signed-off-by: Mohamed Mahmoud mmahmoud@redhat.com