Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2063123: Drop Node update permission for sdn-node #1350

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Bug 2063123: Drop Node update permission for sdn-node #1350

merged 1 commit into from
Apr 25, 2022

Conversation

danwinship
Copy link
Contributor

openshift/sdn#417 makes openshift-sdn-node no longer make use of its Node modifying permissions, so this drops it from its service account.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2022
@openshift-ci openshift-ci bot requested review from abhat and tssurya March 25, 2022 15:34
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2022
@danwinship danwinship mentioned this pull request Apr 5, 2022
Merged
@danwinship danwinship changed the title Drop Node update permission for sdn-node Bug 2063123: Drop Node update permission for sdn-node Apr 14, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2022

@danwinship: This pull request references Bugzilla bug 2063123, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2063123: Drop Node update permission for sdn-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 16, 2022

@danwinship: This pull request references Bugzilla bug 2063123, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from zhaozhanqi April 16, 2022 21:03
@jcaamano
Copy link
Contributor

/retest-required

@danwinship
Copy link
Contributor Author

/hold cancel
@jcaamano or @msherif1234 want to lgtm this too? (It removes the permissions we no longer need post-openshift/sdn#417.)

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2022
@squeed
Copy link
Contributor

squeed commented Apr 25, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2022 •
edited
Loading

@danwinship: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ovn-ipsec-step-registry 98ab169 link false /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-ovn-hybrid-step-registry 98ab169 link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-ovn-step-registry 98ab169 link false /test e2e-ovn-step-registry
ci/prow/e2e-openstack-ovn 98ab169 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-upgrade 98ab169 link false /test e2e-aws-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 98ab169 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit abd843a into openshift:master Apr 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2022

@danwinship: All pull requests linked via external trackers have merged:

Bugzilla bug 2063123 has been moved to the MODIFIED state.

In response to this:

Bug 2063123: Drop Node update permission for sdn-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship danwinship mentioned this pull request Apr 29, 2022
Merged
@danwinship danwinship deleted the sdn-node-permissions branch May 2, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhat abhat Awaiting requested review from abhat

@tssurya tssurya Awaiting requested review from tssurya

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@squeed squeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danwinship @jcaamano @squeed @openshift-bot @openshift-merge-robot