Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovn-kube: move back to unsuffixed RHEL9 images #1747

Merged
merged 1 commit into from Mar 29, 2023
Merged

ovn-kube: move back to unsuffixed RHEL9 images #1747

merged 1 commit into from Mar 29, 2023

Conversation

dcbw
Copy link
Member

@dcbw dcbw commented Mar 23, 2023

Now that we're building the unsuffixed images with RHEL9 we can move back to them.

@openshift-ci openshift-ci bot requested review from abhat and trozet March 23, 2023 05:30
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2023
@dcbw
Copy link
Member Author

dcbw commented Mar 23, 2023

/retest-required

1 similar comment
@dcbw
Copy link
Member Author

dcbw commented Mar 23, 2023

/retest-required

@dcbw
Copy link
Member Author

dcbw commented Mar 23, 2023

/test e2e-vsphere-ovn-windows
https://redhat-internal.slack.com/archives/C015H2WDJRY/p1679602286025539

@dcbw
Copy link
Member Author

dcbw commented Mar 24, 2023

/override ci/prow/e2e-aws-sdn-network-migration-rollback
/override ci/prow/e2e-aws-ovn-network-migration

These haven't passed in a couple days for any PRs.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2023

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-ovn-network-migration, ci/prow/e2e-aws-sdn-network-migration-rollback

In response to this:

/override ci/prow/e2e-aws-sdn-network-migration-rollback
/override ci/prow/e2e-aws-ovn-network-migration

These haven't passed in a couple days for any PRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Member Author

dcbw commented Mar 27, 2023

/retest

2 similar comments
@dcbw
Copy link
Member Author

dcbw commented Mar 27, 2023

/retest

@dcbw
Copy link
Member Author

dcbw commented Mar 27, 2023

/retest

@dcbw
Copy link
Member Author

dcbw commented Mar 27, 2023

/test e2e-vsphere-ovn-windows

1 similar comment
@dcbw
Copy link
Member Author

dcbw commented Mar 28, 2023

/test e2e-vsphere-ovn-windows

@flavio-fernandes
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2023
flavio-fernandes
flavio-fernandes reviewed Mar 28, 2023
View reviewed changes
Copy link
Contributor

@flavio-fernandes flavio-fernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: would it be a good idea to simply revert commit
3a76d93 ?

@dcbw
ovn-kube: move back to unsuffixed RHEL9 images
5f3c02f 
This reverts commit 3a76d93.

Now that we're building the unsuffixed images with RHEL9 we can move back to them.
@dcbw
Copy link
Member Author

dcbw commented Mar 28, 2023

NIT: would it be a good idea to simply revert commit

@flavio-fernandes Yeah, good idea. Done (though I changed the commit title so it didn't look like we were reverting RHEL9 entirely).

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2023
trozet
trozet approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, flavio-fernandes, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dcbw
Copy link
Member Author

dcbw commented Mar 28, 2023

/retest

quota issues, mostly

level=fatal msg=failed to fetch Cluster: failed to fetch dependency of "Cluster": failed to generate asset "Platform Quota Check": error(MissingQuota): compute.googleapis.com/networks is not available in global because the required number of resources (1) is more than remaining quota of 0

@dcbw
Copy link
Member Author

dcbw commented Mar 28, 2023

/retest

@dcbw
Copy link
Member Author

dcbw commented Mar 28, 2023

/retest
aws capacity again

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8832c11 and 2 for PR HEAD 5f3c02f in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ced9472 and 1 for PR HEAD 5f3c02f in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2023

@dcbw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-sdn 5f3c02f link false /test e2e-openstack-sdn
ci/prow/e2e-aws-sdn-upgrade 5f3c02f link false /test e2e-aws-sdn-upgrade
ci/prow/e2e-openstack-ovn 5f3c02f link false /test e2e-openstack-ovn
ci/prow/e2e-gcp-ovn-upgrade 5f3c02f link false /test e2e-gcp-ovn-upgrade
ci/prow/e2e-hypershift-ovn 5f3c02f link false /test e2e-hypershift-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dcbw dcbw merged commit 3ed829e into openshift:master Mar 29, 2023
24 of 30 checks passed
@sjenning
Copy link
Contributor

This broke Hypershift (again)

This was referenced Mar 29, 2023
Merged
Merged
joepvd added a commit to joepvd/ocp-build-data that referenced this pull request Mar 31, 2023
@joepvd
Follow upstream naming change
4e9ed86 
openshift/cluster-network-operator#1747
@joepvd joepvd mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavio-fernandes flavio-fernandes flavio-fernandes left review comments

@trozet trozet trozet approved these changes

@abhat abhat Awaiting requested review from abhat

Assignees

@flavio-fernandes flavio-fernandes

@trozet trozet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dcbw @flavio-fernandes @openshift-ci-robot @sjenning @trozet