Bug 1751246: openshift-sdn: add better ovs liveness/readiness probe #321
Conversation
|
@squeed: This pull request references Bugzilla bug 1751246, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/invalid-bug
|
This can wait until v4.3 cuts. |
openshift-ci-robot
added
do-not-merge/hold
do you have any examples of situations where the current probes are failing us? |
Nothing conclusive, but the linked bug (1751246) hints at this being a possibility. So it would be good to get some more confidence. |
|
@orgcandman thanks for the feedback. Are there any other commands that would provide a useful end-to-end test of ovs-vswitchd or ovsdb? Suggestions? |
|
the appctl command should cover it for ovs-vswitchd. You can make an appctl command to ovsdb also (test something like: ovs-appctl -t ovsdb-server list-commands). But if ovs-vsctl returns then the db is up. |
This changes the liveness/readiness probe for OVS to (hopefully) a more rigorous end-to-end check. The challenge is to find one that doesn't rely on br0 being present, which won't happen until openshift-sdn is up and running. So, we do ovs-ctl status, which checks that the pidfiles have pids that are up and running. It also adds an ovs-appctl command to verify that the vswitchd is running, and a ovs-vsctl check to see that the DB is running.
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@squeed: This pull request references Bugzilla bug 1751246, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@squeed: All pull requests linked via external trackers have merged. Bugzilla bug 1751246 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This changes the liveness/readiness probe for OVS to (hopefully) a more rigorous end-to-end check. The challenge is to find one that doesn't rely on br0 being present, which won't happen until openshift-sdn is up and running.
So, we do ovs-ctl status, which checks that the pidfiles have pids that are up and running. It also adds an ovs-appctl command to verify that the vswitchd is running, and a ovs-vsctl check to see that the DB is running.
/cc @orgcandman