controller/status: set Degraded if rollout is hung. #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/L
openshift-ci-robot
added
size/XL
|
@danwinship rewrote this to store status in a type and marshal it to json. Thanks |
|
/retest |
|
Uh... I was kind of tired when I wrote that comment. I meant to say: I rewrote this to store state in an annotation on the ClusterOperator in json. |
danwinship
reviewed
Nov 7, 2019
If we find ourselves with a DaemonSet or Deployment that hasn't made any progress for the past 10 minutes, then highlight this to the operator as a Degraded state. This doesn't affect any of the other states (Progressing, Available, etc.).
|
Test failure is due to https://bugzilla.redhat.com/show_bug.cgi?id=1765280 |
|
@danwinship updated, PTAL |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we find ourselves with a DaemonSet or Deployment that hasn't made any progress for the past 10 minutes, then highlight this to the operator as a Degraded state.
This doesn't affect any of the other states (Progressing, Available, etc.).
/cc @danwinship @rcarrillocruz