Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1762145: TLS handshake error breaking multus admission controller functionality #362

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Bug 1762145: TLS handshake error breaking multus admission controller functionality #362

merged 1 commit into from
Oct 23, 2019

Conversation

s1061123
Copy link
Contributor

controller-runtime change[1] changes to set namespace hence
multus-admission-controller's caBundle is not supplied by CNO.
This change fixes the condition to invoke to reconcile it.

[1] kubernetes-sigs/controller-runtime@6cfbed3

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2019
@s1061123
Fix condition to reconcile due to controller-runtime change
6310906 
controller-runtime change[1] changes to set namespace hence
multus-admission-controller's caBundle is not supplied by CNO.
This change fixes the condition to invoke to reconcile it.

[1] kubernetes-sigs/controller-runtime@6cfbed3

Signed-off-by: Tomofumi Hayashi <tohayash@redhat.com>
@s1061123 s1061123 changed the title Bug: 1762145 TLS handshake error breaking multus admission controller functionality (edit) Bug 1762145: TLS handshake error breaking multus admission controller functionality (edit) Oct 23, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 23, 2019
@openshift-ci-robot
Copy link
Contributor

@s1061123: This pull request references Bugzilla bug 1762145, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1762145: TLS handshake error breaking multus admission controller functionality (edit)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s1061123
Copy link
Contributor Author

/test e2e-aws
/test e2e-aws-upgrade

1 similar comment
@s1061123
Copy link
Contributor Author

/test e2e-aws
/test e2e-aws-upgrade

@s1061123 s1061123 changed the title Bug 1762145: TLS handshake error breaking multus admission controller functionality (edit) Bug 1762145: TLS handshake error breaking multus admission controller functionality Oct 23, 2019
@s1061123
Copy link
Contributor Author

/test e2e-aws
/test e2e-aws-upgrade

@squeed
Copy link
Contributor

squeed commented Oct 23, 2019

interesting.
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s1061123, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2019
@openshift-merge-robot openshift-merge-robot merged commit f656928 into openshift:master Oct 23, 2019
@openshift-ci-robot
Copy link
Contributor

@s1061123: All pull requests linked via external trackers have merged. Bugzilla bug 1762145 has been moved to the MODIFIED state.

In response to this:

Bug 1762145: TLS handshake error breaking multus admission controller functionality

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s1061123 s1061123 deleted the fix/cabundle branch October 23, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderConstantinescu alexanderConstantinescu Awaiting requested review from alexanderConstantinescu

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@squeed squeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s1061123 @openshift-ci-robot @squeed @openshift-merge-robot