Bug 1851928: [metrics] TargetDown alert is always fired in ovnkube-node job #689
Conversation
openshift-ci-robot
added
the
bugzilla/severity-high
|
@tssurya: This pull request references Bugzilla bug 1851928, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/retest |
1 similar comment
|
/retest |
|
/assign @rcarrillocruz The CI failures are unrelated. Not sure why the CI is acting crazy. |
Small typo there, besides that, there have been a lot of CI issues, so let's retest it again, I had similar issues and they ought to be fixed now. |
|
/retest |
…de job The TargetDown alert was always getting fired for all the ovnkube-nodes because the metrics-bind-address flag was not getting passed in the exec command for the ovnkube-node container. This regression was introduced in PR openshift#615. Prometheus was hence not able to scrape the up metrics. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-gcp |
|
/test e2e-gcp |
|
/retest |
|
/test e2e-windows-hybrid-network |
|
/retest |
|
/test e2e-windows-hybrid-network |
|
/test e2e-vsphere |
|
/retest |
|
/lgtm
note that not all of the tests are required to pass; look in the list of tests at the bottom of the PR (just above the new-comment box); if it doesn't show "Required" next to the test, then it doesn't matter that it failed |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
ah good to know! thanks Dan for approving. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
15 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@tssurya: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@tssurya: All pull requests linked via external trackers have merged: openshift/cluster-network-operator#689. Bugzilla bug 1851928 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.5 |
|
@vrutkovs: new pull request created: #697 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The TargetDown alert was always getting fired for all the ovnkube-nodes
because the metrics-bind-address flag was not getting passed in the exec
command for the ovnkube-node container. This regression was introduced
in PR #615. Promethues was hence not able to scrape the up metrics.
Signed-off-by: Surya Seetharaman suryaseetharaman.9@gmail.com