Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.5] Bug 1854736: [metrics] TargetDown alert is always fired in ovnkube-node job #697

Merged
merged 1 commit into from Jul 13, 2020
Merged

[release-4.5] Bug 1854736: [metrics] TargetDown alert is always fired in ovnkube-node job #697

merged 1 commit into from Jul 13, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #689

/assign vrutkovs

@tssurya
Bug 1851928: [metrics] TargetDown alert is always fired in ovnkube-no…
277c5a4 
…de job

The TargetDown alert was always getting fired for all the ovnkube-nodes
because the metrics-bind-address flag was not getting passed in the exec
command for the ovnkube-node container. This regression was introduced
in  PR openshift#615. Prometheus was hence not able to scrape the up metrics.

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 8, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1851928 has been cloned as Bugzilla bug 1854736. Retitling PR to link against new bug.
/retitle [release-4.5] Bug 1854736: [metrics] TargetDown alert is always fired in ovnkube-node job

In response to this:

[release-4.5] Bug 1851928: [metrics] TargetDown alert is always fired in ovnkube-node job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Bug 1851928: [metrics] TargetDown alert is always fired in ovnkube-node job [release-4.5] Bug 1854736: [metrics] TargetDown alert is always fired in ovnkube-node job Jul 8, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jul 8, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1854736, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1851928 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1851928 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

[release-4.5] Bug 1854736: [metrics] TargetDown alert is always fired in ovnkube-node job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 8, 2020
@vrutkovs
Copy link
Member

vrutkovs commented Jul 8, 2020

/retest

2 similar comments
@vrutkovs
Copy link
Member

vrutkovs commented Jul 8, 2020

/retest

@vrutkovs
Copy link
Member

vrutkovs commented Jul 8, 2020

/retest

@dcbw
Copy link
Contributor

dcbw commented Jul 8, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2020
@knobunc
Copy link
Contributor

knobunc commented Jul 8, 2020

@sdodson can we get this one approved?

@dcbw dcbw mentioned this pull request Jul 8, 2020
Closed
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@dcbw
Copy link
Contributor

dcbw commented Jul 8, 2020

/bugzilla refresh

1 similar comment
@dcbw
Copy link
Contributor

dcbw commented Jul 8, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@dcbw: This pull request references Bugzilla bug 1854736, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1851928 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1851928 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. and removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Jul 8, 2020
@openshift-ci-robot
Copy link
Contributor

@dcbw: This pull request references Bugzilla bug 1854736, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1851928 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1851928 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Jul 9, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 9, 2020
@openshift-ci-robot
Copy link
Contributor

@sdodson: This pull request references Bugzilla bug 1854736, which is invalid:

  • expected dependent Bugzilla bug 1851928 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 9, 2020
@dcbw
Copy link
Contributor

dcbw commented Jul 13, 2020

aws-sdn-single failure is unrelated to this PR since that job is for openshift-sdn and this is an ovnkube PR. Also looks like a CRIO problem to begin with:

"message": "Failed to create pod sandbox: rpc error: code = Unknown desc = error creating pod sandbox with name \"k8s_sdn-85r8q_openshift-sdn_5c3a5e2e-fcb8-4827-b3a7-7e91e7444925_0\": layer not known",

@dcbw
Copy link
Contributor

dcbw commented Jul 13, 2020

/override e2e-aws-sdn-single

@openshift-ci-robot
Copy link
Contributor

@dcbw: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • e2e-aws-sdn-single

Only the following contexts were expected:

  • ci/prow/e2e-aws-sdn-multi
  • ci/prow/e2e-aws-sdn-single
  • ci/prow/e2e-gcp
  • ci/prow/e2e-gcp-upgrade
  • ci/prow/e2e-metal-ipi
  • ci/prow/e2e-ovn-hybrid-step-registry
  • ci/prow/e2e-ovn-step-registry
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • tide

In response to this:

/override e2e-aws-sdn-single

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Jul 13, 2020

/override ci/prow/e2e-aws-sdn-single

@openshift-ci-robot
Copy link
Contributor

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-sdn-single

In response to this:

/override ci/prow/e2e-aws-sdn-single

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 076a2c6 into openshift:release-4.5 Jul 13, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/cluster-network-operator#697. Bugzilla bug 1854736 has been moved to the MODIFIED state.

In response to this:

[release-4.5] Bug 1854736: [metrics] TargetDown alert is always fired in ovnkube-node job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderConstantinescu alexanderConstantinescu Awaiting requested review from alexanderConstantinescu

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

Assignees

@vrutkovs vrutkovs

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @openshift-ci-robot @vrutkovs @dcbw @knobunc @openshift-bot @sdodson @openshift-merge-robot @tssurya