New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1874638: Fixes missing nbctl daemon logging #772
Bug 1874638: Fixes missing nbctl daemon logging #772
Conversation
@astoycos FYI |
/bugzilla refresh |
Thanks @trozet this should help in debugging future issues between |
/lgtm |
|
||
# include nbctl daemon logging, allow for ovn-nbctl to create the log file | ||
sleep 1 | ||
tail -f /run/ovn/ovn-nbctl.log & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add --retry
to the tail
args and then it will work even if "sleep 1" isn't long enough.
(You could theoretically get rid of the "sleep 1" entirely, but then tail would log a pointless warning, so it's best to have both.)
39553c1
to
cfff586
Compare
Jinx! So the problem I was saying is, the way it is now, you'll get:
ugh, and actually you get
too. Way to be useless, |
hmm not seeing the nbctl logs |
Signed-off-by: Tim Rozet <trozet@redhat.com>
cfff586
to
8aa3078
Compare
/retest |
I see a bunch of ovn-nbctl logging now in the ovn-kube logs. |
/retest |
2 similar comments
/retest |
/retest |
@trozet: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
--db "{{.OVN_NB_DB_LIST}}" --log-file=/run/ovn/ovn-nbctl.log) | ||
|
||
# include nbctl daemon logging, allow for ovn-nbctl to create the log file | ||
tail -f --retry /run/ovn/ovn-nbctl.log & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to tail it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we can see exactly in the ovnkube-master logs when the commands happen. Really helpful in debugging. I suspect as we migrate more and more to the golang bindings they will eventually go away, but it's a good way to track things as well that need to get migrated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I should have provided more context. I meant, yes, its useful to tail it, but that data is already in the log file on disk. But I suppose the real value add is the interleaving of those commands with the master logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-f --retry
is --follow=descriptor --retry
whereas the usual -F
is --follow=name --retry
-f, --follow[={name|descriptor}]
output appended data as the file grows;
an absent option argument means 'descriptor'
We usually want --follow=name
, is there a reason we are only following descriptor.
Also, do we want --pid=$(cat /var/run/ovn/ovn-nbctl.pid)
as in the other tail commands to stop the tail once the daemon stops?
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhat, astoycos, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@abhat It's weird the merge bot is still not recognizing |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/override e2e-openstack |
@abhat: /override requires a failed status context to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/e2e-openstack |
@abhat: Overrode contexts on behalf of abhat: ci/prow/e2e-openstack In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Please review the full test history for this PR and help us cut down flakes. |
10 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@trozet: All pull requests linked via external trackers have merged: Bugzilla bug 1874638 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Tim Rozet trozet@redhat.com