New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1880591: 4.6 Use ovs-configuration file to determine if OVS is running in systemd #825
Bug 1880591: 4.6 Use ovs-configuration file to determine if OVS is running in systemd #825
Conversation
@trozet: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-gcp-ovn |
@trozet: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-gcp-ovn-upgrade |
/lgtm |
@trozet: This pull request references Bugzilla bug 1880591, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@trozet: This pull request references Bugzilla bug 1880591, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
2 similar comments
/retest |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
vsphere and hybrid step are only failing: which is being fixed by #824 |
/override ci/prow/e2e-ovn-hybrid-step-registry |
/override ci/prow/e2e-vsphere-ovn |
/retest |
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, juanluisvaladas, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold until I can verify job logs and cluster bot upgrades |
logs look ok to me /hold cancel |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
@juanluisvaladas @tssurya I'm seeing vsphere failed because:
I don't see ovnkube master container go down. The value here looks suspicious:[1602096410.162,"1"] but I don't know anything about prom alerts. This PR run included the fix for #826 |
vsphere passed all tests and is running in systemd OVS. The alert was the only thing it failed...overriding /override ci/prow/e2e-vsphere-ovn |
@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-vsphere-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This alert's value is indeed strange.. usually it doesn't exceed 100 since we take a percentage of the value. So for example since we have 3 ovnkube-master pods and say one of the metrics port is not reachable, then 1/3*100 = 33.33 would be the value. I have no idea how the value here is so huge :D |
First is a timestamp, the second one is value. I'm seeing similar alerts in OKD nightly runs, seems started at around Oct 3 and flaking pretty often |
For this particular run, there are clearly some issues: Although I don't see this alert in previous runs of this job. |
This should have got fixed with #826 |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/override ci/prow/e2e-vsphere-ovn |
@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-vsphere-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@trozet: All pull requests linked via external trackers have merged:
Bugzilla bug 1880591 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -52,7 +52,7 @@ spec: | |||
} | |||
|
|||
# Check to see if ovs is provided by the node: | |||
if [[ -L '/host/etc/systemd/system/network-online.target.wants/ovs-configuration.service' ]]; then | |||
if [ -f /host/var/run/ovs-config-executed ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this file gets generated? I don't see it being created by MCO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openshift/machine-config-operator#2140
only in release-4.6 branch
https://github.com/openshift/machine-config-operator/blob/release-4.6/templates/common/_base/files/configure-ovs-network.yaml#L9
in 4.7 we should only run host OVS, so I think the plan is to remove this if
.
Checking files or symlinks on disks seems to be flaky and there are time
windows where files are laid down on the disk but the running version is
still 4.5. This changes the logic to determine if OVS is running on the
host by checking the for a file generated when ovs-configuration is
executed.
Signed-off-by: Tim Rozet trozet@redhat.com