Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Nodes Network MTU on Installations with Kuryr #853

Merged

Conversation

MaysaMacedo
Copy link
Contributor

This commit adds the support to detect the Nodes
Network MTU so that the Namespace Networks use the
same MTU as the host.

@MaysaMacedo MaysaMacedo changed the title Detect Nodes Network MTU wip: Detect Nodes Network MTU Oct 27, 2020
@MaysaMacedo
Copy link
Contributor Author

Need to test with the support added on Kuryr.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2020
@MaysaMacedo MaysaMacedo force-pushed the detect-nodes-network-mtu branch 2 times, most recently from 1bb4a97 to fde72da Compare October 29, 2020 11:35
In order to retrieve the MTU of a Network, the mtu
extensions must be enabled and available in the
Gophercloud dependencies.
This commit adds the support to detect the Nodes
Network MTU so that the Namespace Networks use the
same MTU as the host.
@MaysaMacedo MaysaMacedo changed the title wip: Detect Nodes Network MTU Detect Nodes Network MTU Oct 29, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2020
Copy link
Member

@gryf gryf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how it is work in golang, but

pkg/platform/openstack/networking.go Show resolved Hide resolved
@MaysaMacedo MaysaMacedo changed the title Detect Nodes Network MTU Detect Nodes Network MTU on Installations with Kuryr Oct 30, 2020
@MaysaMacedo
Copy link
Contributor Author

/assign @dulek

@MaysaMacedo
Copy link
Contributor Author

Need to test with the support added on Kuryr.

worked fine.

@dulek
Copy link
Contributor

dulek commented Nov 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2020
@dulek
Copy link
Contributor

dulek commented Nov 2, 2020

/approve

@MaysaMacedo
Copy link
Contributor Author

/assign @squeed

@squeed
Copy link
Contributor

squeed commented Nov 4, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, MaysaMacedo, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1ee0aaf into openshift:master Nov 5, 2020
@MaysaMacedo MaysaMacedo deleted the detect-nodes-network-mtu branch November 5, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants