New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1910111: order startup of IPsec components #929
Bug 1910111: order startup of IPsec components #929
Conversation
@markdgray: This pull request references Bugzilla bug 1910111, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c284f9a
to
a045271
Compare
/cc dwinship |
@markdgray: GitHub didn't allow me to request PR reviews from the following users: dwinship. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a045271
to
64cb21f
Compare
/retest |
2 similar comments
/retest |
/retest |
64cb21f
to
82953b2
Compare
Updated the comment as per @squeed 's request. |
/retest |
1 similar comment
/retest |
On cluster startup, ensure ovnkube-node has finished configuring the node before starting IPsec.
In order to start 'ovs-monitor-ipsec' with a known good state, we flush 'xfrm' policy and state just after startup. As we do not flush state on shutdown, we can maintain connectivity (but not establish new connections) until the container restarts. This will mean there will be a short interruption of connectivity between flushing xfrm state and 'ovs-monitor-ipsec' startup. Signed-off-by: Mark Gray <mark.d.gray@redhat.com>
We don't need to render the IPsec manifest via a conditional in the code; we can just render it conditionally via the template like we do with some other manifests. Signed-off-by: Dan Winship <danwinship@redhat.com>
82953b2
to
91db34b
Compare
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, markdgray The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
12 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@markdgray: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@markdgray: All pull requests linked via external trackers have merged: Bugzilla bug 1910111 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.