Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1910111: order startup of IPsec components #929

Conversation

markdgray
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Dec 22, 2020
@openshift-ci-robot
Copy link
Contributor

@markdgray: This pull request references Bugzilla bug 1910111, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1910111: order startup of IPsec components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 22, 2020
@markdgray markdgray force-pushed the fix/ipsec_startup_order/1910111 branch from c284f9a to a045271 Compare December 22, 2020 17:57
@markdgray
Copy link
Contributor Author

/cc dwinship

@openshift-ci-robot
Copy link
Contributor

@markdgray: GitHub didn't allow me to request PR reviews from the following users: dwinship.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc dwinship

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@markdgray
Copy link
Contributor Author

/retest

2 similar comments
@markdgray
Copy link
Contributor Author

/retest

@markdgray
Copy link
Contributor Author

/retest

@markdgray markdgray force-pushed the fix/ipsec_startup_order/1910111 branch from 64cb21f to 82953b2 Compare January 5, 2021 11:12
@markdgray
Copy link
Contributor Author

Updated the comment as per @squeed 's request.

@markdgray
Copy link
Contributor Author

/retest

1 similar comment
@markdgray
Copy link
Contributor Author

/retest

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2021
markdgray and others added 3 commits January 5, 2021 18:05
On cluster startup, ensure ovnkube-node has finished configuring the
node before starting IPsec.
In order to start 'ovs-monitor-ipsec' with a known good state, we
flush 'xfrm' policy and state just after startup. As we do not flush
state on shutdown, we can maintain connectivity (but not establish new
connections) until the container restarts. This will mean there will
be a short interruption of connectivity between flushing xfrm state
and 'ovs-monitor-ipsec' startup.

Signed-off-by: Mark Gray <mark.d.gray@redhat.com>
We don't need to render the IPsec manifest via a conditional in the
code; we can just render it conditionally via the template like we do
with some other manifests.

Signed-off-by: Dan Winship <danwinship@redhat.com>
@markdgray markdgray force-pushed the fix/ipsec_startup_order/1910111 branch from 82953b2 to 91db34b Compare January 5, 2021 23:05
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2021
@markdgray
Copy link
Contributor Author

/retest

@dcbw
Copy link
Member

dcbw commented Jan 6, 2021

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, markdgray

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2021

@markdgray: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure-ovn 91db34b link /test e2e-azure-ovn
ci/prow/e2e-aws-ovn-windows 91db34b link /test e2e-aws-ovn-windows
ci/prow/e2e-aws-ovn-windows-custom-vxlan 91db34b link /test e2e-aws-ovn-windows-custom-vxlan

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit cd4f877 into openshift:master Jan 6, 2021
@openshift-ci-robot
Copy link
Contributor

@markdgray: All pull requests linked via external trackers have merged:

Bugzilla bug 1910111 has been moved to the MODIFIED state.

In response to this:

Bug 1910111: order startup of IPsec components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@markdgray markdgray deleted the fix/ipsec_startup_order/1910111 branch February 9, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants