Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1912820: competing connectivitycheckcontrollers cause pod restarts during upgrades #970

Merged
merged 3 commits into from Feb 8, 2021
Merged

Bug 1912820: competing connectivitycheckcontrollers cause pod restarts during upgrades #970

merged 3 commits into from Feb 8, 2021

Conversation

sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Feb 4, 2021 •
edited

  • pickup library-go#987
  • remove podnetworkconnectivitycheck from CVO control

@sanchezl sanchezl changed the title connectivitycheckcontroller upgrade proof: pickup openshift/library-go#987 Feb 4, 2021
@sanchezl sanchezl force-pushed the connectivitycheckcontroller-upgrade branch 2 times, most recently from d8a35d5 to 708b0a0 Compare February 4, 2021 03:45
@danwinship
Copy link
Contributor

danwinship commented Feb 4, 2021 •
edited

proof: pickup openshift/library-go#987

I think people generally try to avoid using strings that will trigger github's automatic linking-via-commit-message, since it tends to totally spam the linked PR/issue (eg, another message every time you push an updated version of the commit)

@danwinship
Copy link
Contributor

lgtm
/hold
for the library-go change to actually merge

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2021
@sanchezl sanchezl force-pushed the connectivitycheckcontroller-upgrade branch 2 times, most recently from 572f1c8 to 0f858ce Compare February 4, 2021 16:19
@sanchezl sanchezl force-pushed the connectivitycheckcontroller-upgrade branch 2 times, most recently from 9ff8b8a to 7439dd4 Compare February 5, 2021 16:33
@sanchezl
Copy link
Contributor Author

sanchezl commented Feb 5, 2021

/retest

@sanchezl sanchezl mentioned this pull request Feb 5, 2021
Closed
@sanchezl sanchezl changed the title proof: pickup openshift/library-go#987 Bug 1912820: competing connectivitycheckcontrollers cause pod restarts during upgrades Feb 5, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Feb 5, 2021
@openshift-ci-robot
Copy link
Contributor

@sanchezl: This pull request references Bugzilla bug 1912820, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1912820: competing connectivitycheckcontrollers cause pod restarts during upgrades

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 5, 2021
@openshift-ci-robot
Copy link
Contributor

@sanchezl: This pull request references Bugzilla bug 1912820, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1912820: competing connectivitycheckcontrollers cause pod restarts during upgrades

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanchezl
Copy link
Contributor Author

sanchezl commented Feb 5, 2021

/retest

2 similar comments
@sanchezl
Copy link
Contributor Author

sanchezl commented Feb 5, 2021

/retest

@sanchezl
Copy link
Contributor Author

sanchezl commented Feb 6, 2021

/retest

@deads2k
Copy link
Contributor

deads2k commented Feb 8, 2021

  • remove podnetworkconnectivitycheck from CVO control

For the future, using the CVO prevents any conditional creation, list/watch reaction speed, conditional removal, selective mutation, coordination between operators. It is basically always better to avoid the CVO.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2021
@danwinship
Copy link
Contributor

/hold cancel
/approve

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, deads2k, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c253257 into openshift:master Feb 8, 2021
@openshift-ci-robot
Copy link
Contributor

@sanchezl: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1912820 has not been moved to the MODIFIED state.

In response to this:

Bug 1912820: competing connectivitycheckcontrollers cause pod restarts during upgrades

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@sanchezl: cannot checkout 4.7: error checking out 4.7: exit status 1. output: error: pathspec '4.7' did not match any file(s) known to git

In response to this:

/cherry-pick 4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 7, 2021

/cherry-pick release-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 7, 2021
Merged
@openshift-cherrypick-robot
Copy link

@sanchezl: new pull request created: #1050

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@trozet trozet Awaiting requested review from trozet

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sanchezl @danwinship @openshift-ci-robot @deads2k @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot