Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Csv config fixes #29

Merged
merged 3 commits into from Sep 20, 2019
Merged

Csv config fixes #29

merged 3 commits into from Sep 20, 2019
+54 −4

Conversation

zvonkok
Copy link
Contributor

@zvonkok zvonkok commented Sep 19, 2019

This PR fixes several bugs for NFD.

  • Updated CSV with correct version
  • Updated CSV and added contact email (operator-courier was not complaining)
  • Added new state to configure Namespace
  • Added namespace to CR for confiruation where to install the operand

@zvonkok zvonkok requested a review from sjug September 19, 2019 17:12
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 19, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2019
@zvonkok zvonkok removed the request for review from courtneypacheco September 19, 2019 17:16
sjug
sjug reviewed Sep 19, 2019
View reviewed changes
Copy link

@sjug sjug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small stylistic nits but otherwise looks fine and consistent with previous functions.

manifests/olm-catalog/4.2/nfd.v4.2.0.clusterserviceversion.yaml Outdated Show resolved Hide resolved
pkg/controller/nodefeaturediscovery/nodefeaturediscovery_controls.go Show resolved Hide resolved
pkg/controller/nodefeaturediscovery/nodefeaturediscovery_controls.go Show resolved Hide resolved
pkg/controller/nodefeaturediscovery/nodefeaturediscovery_controls.go Outdated Show resolved Hide resolved
@sjug
Copy link

sjug commented Sep 20, 2019

/lgtm

Pending squash

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjug, zvonkok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zvonkok zvonkok merged commit c83b846 into master Sep 20, 2019
@stevekuznetsov stevekuznetsov deleted the csv-config-fixes branch November 20, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjug sjug sjug left review comments

Assignees

@sjug sjug

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zvonkok @sjug @openshift-ci-robot @psap-ci-robot