Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator upgrade issues. #103

Merged
merged 1 commit into from Jan 21, 2020
Merged

Operator upgrade issues. #103

merged 1 commit into from Jan 21, 2020

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Jan 17, 2020

Changes:

  • sync default custom tuned resource on operator (re)start
  • sync daemonset when operator release ver != daemonset release ver

@jmencak
Operator upgrade issues.
bcb4902 
Changes:
  - sync default custom tuned resource on operator (re)start
  - sync daemonset when operator release ver != daemonset release ver
@jmencak jmencak requested a review from sjug January 17, 2020 11:22
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 17, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2020
sjug
sjug approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@sjug sjug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, sjug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmencak
Copy link
Contributor Author

jmencak commented Jan 20, 2020

/test e2e-aws

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jmencak
Copy link
Contributor Author

jmencak commented Jan 20, 2020

/test e2e-aws-upgrade

1 similar comment
@jmencak
Copy link
Contributor Author

jmencak commented Jan 20, 2020

/test e2e-aws-upgrade

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jmencak
Copy link
Contributor Author

jmencak commented Jan 21, 2020

/retest

@jmencak
Copy link
Contributor Author

jmencak commented Jan 21, 2020

/test e2e-aws-upgrade

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c6b84bd into openshift:master Jan 21, 2020
@jmencak jmencak deleted the 4.4-cr-ds-sync branch January 21, 2020 21:41
@bparees bparees mentioned this pull request Feb 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjug sjug sjug approved these changes

@courtneypacheco courtneypacheco Awaiting requested review from courtneypacheco

Assignees

@sjug sjug

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jmencak @openshift-ci-robot @openshift-bot @sjug @openshift-merge-robot