New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry handling of profile changes on errors. #117
Retry handling of profile changes on errors. #117
Conversation
A race condition exists between extracting tuned daemon profiles CR into /etc/tuned directory and the pre-calculated profile CR. If the pre-calculated profile CR is set and processed prior to the tuned profiles being present in /etc/tuned a possibility exists the calculated profile will not be set. This change fixes the issue and corrects a Makefile prerequisite name.
/assign @sjug |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, sjug The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/cherry-pick release-4.4 |
@jmencak: new pull request created: #118 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
A race condition exists between extracting tuned daemon profiles CR into
/etc/tuned
directory and applying the pre-calculated profile CR. If the pre-calculatedprofile CR is set and processed prior to the tuned profiles being present in
/etc/tuned
a possibility exists the calculated profile will not be set.This change fixes the issue and corrects a
Makefile
prerequisite name.