Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry handling of profile changes on errors. #117

Merged

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Mar 11, 2020

A race condition exists between extracting tuned daemon profiles CR into
/etc/tuned directory and applying the pre-calculated profile CR. If the pre-calculated
profile CR is set and processed prior to the tuned profiles being present in
/etc/tuned a possibility exists the calculated profile will not be set.

This change fixes the issue and corrects a Makefile prerequisite name.

A race condition exists between extracting tuned daemon profiles CR into
/etc/tuned directory and the pre-calculated profile CR.  If the pre-calculated
profile CR is set and processed prior to the tuned profiles being present in
/etc/tuned a possibility exists the calculated profile will not be set.

This change fixes the issue and corrects a Makefile prerequisite name.
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 11, 2020
@jmencak
Copy link
Contributor Author

jmencak commented Mar 11, 2020

/assign @sjug

@sjug
Copy link
Contributor

sjug commented Mar 13, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, sjug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jmencak
Copy link
Contributor Author

jmencak commented Mar 13, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit e4bcbbe into openshift:master Mar 13, 2020
@jmencak
Copy link
Contributor Author

jmencak commented Mar 17, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot

@jmencak: new pull request created: #118

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak jmencak deleted the 4.5-openshift-tuned-race branch March 19, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants