New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2e test cleanup. #183
E2e test cleanup. #183
Conversation
Changes: - removing code duplication in test/e2e/util/util.go - documentation for functions in test/e2e/util/util.go - more expressive function names where poll.Wait() is used - more flexibility in terms of specifying the interval and timeout for poll.Wait() - for two e2e tests involving reboots removed a check for the original kernel command line parameters as the reboots can now cause changes not only to "ostree", but also to "root", "rhcos.root", "rw"; this would be difficult to maintain in the future - adhere more to k8s naming conventions ([Pp]od, ...)
/assign @courtneypacheco |
/test e2e-aws |
/retest |
Run in a OCP 4.6.5 , I am getting $ make test-e2e
[...]
• Failure [309.232 seconds]
[basic][default_irq_smp_affinity] Node Tuning Operator set irq default smp affinity
/home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:20
irq default smp affinity
/home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:29
default_irq_smp_affinity: /proc/irq/default_smp_affinity set [It]
/home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:44
Unexpected error:
<*errors.errorString | 0xc00055fbc0>: {
s: "command [cat /proc/irq/default_smp_affinity] outputs (leading/trailing whitespace trimmed) 0001 in Pod tuned-8gwnh, expected 7ffd: <nil>",
}
command [cat /proc/irq/default_smp_affinity] outputs (leading/trailing whitespace trimmed) 0001 in Pod tuned-8gwnh, expected 7ffd: <nil>
occurred
/home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:82
------------------------------
SSSS
Summarizing 1 Failure:
[Fail] [basic][default_irq_smp_affinity] Node Tuning Operator set irq default smp affinity irq default smp affinity [It] default_irq_smp_affinity: /proc/irq/default_smp_affinity set
/home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:82
Ran 4 of 8 Specs in 361.148 seconds
FAIL! -- 3 Passed | 1 Failed | 0 Pending | 4 Skipped
--- FAIL: TestNodeTuningOperator (361.15s)
FAIL
FAIL github.com/openshift/cluster-node-tuning-operator/test/e2e/basic 361.160s
FAIL
make: *** [Makefile:91: test-e2e] Error 1 |
Hey Eduardo, thanks for looking! |
Then the PR looks good to me, will leave to @courtneypacheco to approve |
/retest |
3 similar comments
/retest |
/retest |
/retest |
I'm having the same issues as Eduardo on OCP version
|
There is no such a thing as Ideally, you want to build your own custom image to test or trust |
@courtneypacheco the current e2e tests (in this PR) work without any issues for me on |
/uncc @Deepthidharwar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch makes sense and add the described value
I see. My nightly didn't contain #179. I apologize. I was able to test everything and it looks good to me now after running the e2e tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: courtneypacheco, jmencak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
Thank you for the review, @courtneypacheco |
Changes:
test/e2e/util/util.go
test/e2e/util/util.go
poll.Wait()
is usedtimeout for
poll.Wait()
original kernel command line parameters as the reboots can now
cause changes not only to "ostree", but also to "root",
"rhcos.root", "rw"; this would be difficult to maintain in the
future