Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e test cleanup. #183

Merged
merged 1 commit into from Nov 30, 2020
Merged

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Nov 25, 2020

Changes:

  • removing code duplication in test/e2e/util/util.go
  • documentation for functions in test/e2e/util/util.go
  • more expressive function names where poll.Wait() is used
  • more flexibility in terms of specifying the interval and
    timeout for poll.Wait()
  • for two e2e tests involving reboots removed a check for the
    original kernel command line parameters as the reboots can now
    cause changes not only to "ostree", but also to "root",
    "rhcos.root", "rw"; this would be difficult to maintain in the
    future
  • adhere more to k8s naming conventions ([Pp]od, ...)

Changes:
  - removing code duplication in test/e2e/util/util.go
  - documentation for functions in test/e2e/util/util.go
  - more expressive function names where poll.Wait() is used
  - more flexibility in terms of specifying the interval and
    timeout for poll.Wait()
  - for two e2e tests involving reboots removed a check for the
    original kernel command line parameters as the reboots can now
    cause changes not only to "ostree", but also to "root",
    "rhcos.root", "rw";  this would be difficult to maintain in the
    future
  - adhere more to k8s naming conventions ([Pp]od, ...)
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2020
@jmencak
Copy link
Contributor Author

jmencak commented Nov 25, 2020

/assign @courtneypacheco

@jmencak
Copy link
Contributor Author

jmencak commented Nov 25, 2020

/test e2e-aws

@jmencak
Copy link
Contributor Author

jmencak commented Nov 25, 2020

/retest

@ArangoGutierrez
Copy link
Contributor

Run in a OCP 4.6.5 , I am getting

$ make test-e2e
[...]
• Failure [309.232 seconds]
[basic][default_irq_smp_affinity] Node Tuning Operator set irq default smp affinity
/home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:20
  irq default smp affinity
  /home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:29
    default_irq_smp_affinity: /proc/irq/default_smp_affinity set [It]
    /home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:44

    Unexpected error:
        <*errors.errorString | 0xc00055fbc0>: {
            s: "command [cat /proc/irq/default_smp_affinity] outputs (leading/trailing whitespace trimmed) 0001 in Pod tuned-8gwnh, expected 7ffd: <nil>",
        }
        command [cat /proc/irq/default_smp_affinity] outputs (leading/trailing whitespace trimmed) 0001 in Pod tuned-8gwnh, expected 7ffd: <nil>
    occurred

    /home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:82
------------------------------
SSSS

Summarizing 1 Failure:

[Fail] [basic][default_irq_smp_affinity] Node Tuning Operator set irq default smp affinity irq default smp affinity [It] default_irq_smp_affinity: /proc/irq/default_smp_affinity set 
/home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:82

Ran 4 of 8 Specs in 361.148 seconds
FAIL! -- 3 Passed | 1 Failed | 0 Pending | 4 Skipped
--- FAIL: TestNodeTuningOperator (361.15s)
FAIL
FAIL    github.com/openshift/cluster-node-tuning-operator/test/e2e/basic        361.160s
FAIL
make: *** [Makefile:91: test-e2e] Error 1

@jmencak
Copy link
Contributor Author

jmencak commented Nov 25, 2020

Run in a OCP 4.6.5 , I am getting

$ make test-e2e
[...]
• Failure [309.232 seconds]
[basic][default_irq_smp_affinity] Node Tuning Operator set irq default smp affinity
/home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:20
  irq default smp affinity
  /home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:29
    default_irq_smp_affinity: /proc/irq/default_smp_affinity set [It]
    /home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:44

    Unexpected error:
        <*errors.errorString | 0xc00055fbc0>: {
            s: "command [cat /proc/irq/default_smp_affinity] outputs (leading/trailing whitespace trimmed) 0001 in Pod tuned-8gwnh, expected 7ffd: <nil>",
        }
        command [cat /proc/irq/default_smp_affinity] outputs (leading/trailing whitespace trimmed) 0001 in Pod tuned-8gwnh, expected 7ffd: <nil>
    occurred

    /home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:82
------------------------------
SSSS

Summarizing 1 Failure:

[Fail] [basic][default_irq_smp_affinity] Node Tuning Operator set irq default smp affinity irq default smp affinity [It] default_irq_smp_affinity: /proc/irq/default_smp_affinity set 
/home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:82

Ran 4 of 8 Specs in 361.148 seconds
FAIL! -- 3 Passed | 1 Failed | 0 Pending | 4 Skipped
--- FAIL: TestNodeTuningOperator (361.15s)
FAIL
FAIL    github.com/openshift/cluster-node-tuning-operator/test/e2e/basic        361.160s
FAIL
make: *** [Makefile:91: test-e2e] Error 1

Hey Eduardo, thanks for looking! irq default smp affinity functionality is only supported in 4.7+ This is expected in 4.6.

@ArangoGutierrez
Copy link
Contributor

Run in a OCP 4.6.5 , I am getting

$ make test-e2e
[...]
• Failure [309.232 seconds]
[basic][default_irq_smp_affinity] Node Tuning Operator set irq default smp affinity
/home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:20
  irq default smp affinity
  /home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:29
    default_irq_smp_affinity: /proc/irq/default_smp_affinity set [It]
    /home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:44

    Unexpected error:
        <*errors.errorString | 0xc00055fbc0>: {
            s: "command [cat /proc/irq/default_smp_affinity] outputs (leading/trailing whitespace trimmed) 0001 in Pod tuned-8gwnh, expected 7ffd: <nil>",
        }
        command [cat /proc/irq/default_smp_affinity] outputs (leading/trailing whitespace trimmed) 0001 in Pod tuned-8gwnh, expected 7ffd: <nil>
    occurred

    /home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:82
------------------------------
SSSS

Summarizing 1 Failure:

[Fail] [basic][default_irq_smp_affinity] Node Tuning Operator set irq default smp affinity irq default smp affinity [It] default_irq_smp_affinity: /proc/irq/default_smp_affinity set 
/home/eduardo/sdk/github/openshift/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:82

Ran 4 of 8 Specs in 361.148 seconds
FAIL! -- 3 Passed | 1 Failed | 0 Pending | 4 Skipped
--- FAIL: TestNodeTuningOperator (361.15s)
FAIL
FAIL    github.com/openshift/cluster-node-tuning-operator/test/e2e/basic        361.160s
FAIL
make: *** [Makefile:91: test-e2e] Error 1

Hey Eduardo, thanks for looking! irq default smp affinity functionality is only supported in 4.7+ This is expected in 4.6.

Then the PR looks good to me, will leave to @courtneypacheco to approve

@jmencak
Copy link
Contributor Author

jmencak commented Nov 25, 2020

/retest

3 similar comments
@jmencak
Copy link
Contributor Author

jmencak commented Nov 25, 2020

/retest

@jmencak
Copy link
Contributor Author

jmencak commented Nov 25, 2020

/retest

@jmencak
Copy link
Contributor Author

jmencak commented Nov 25, 2020

/retest

@courtneypacheco
Copy link

I'm having the same issues as Eduardo on OCP version 4.7.0-0.nightly:

• Failure [303.813 seconds]
[basic][default_irq_smp_affinity] Node Tuning Operator set irq default smp affinity
/home/cpacheco/Documents/aws/build/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:20
  irq default smp affinity
  /home/cpacheco/Documents/aws/build/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:29
    default_irq_smp_affinity: /proc/irq/default_smp_affinity set [It]
    /home/cpacheco/Documents/aws/build/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:44

    Unexpected error:
        <*errors.errorString | 0xc00029cf60>: {
            s: "command [cat /proc/irq/default_smp_affinity] outputs (leading/trailing whitespace trimmed) 0001 in Pod tuned-wv9nw, expected 7ffd: <nil>",
        }
        command [cat /proc/irq/default_smp_affinity] outputs (leading/trailing whitespace trimmed) 0001 in Pod tuned-wv9nw, expected 7ffd: <nil>
    occurred

    /home/cpacheco/Documents/aws/build/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:82
------------------------------
SSS

Summarizing 1 Failure:

[Fail] [basic][default_irq_smp_affinity] Node Tuning Operator set irq default smp affinity irq default smp affinity [It] default_irq_smp_affinity: /proc/irq/default_smp_affinity set 
/home/cpacheco/Documents/aws/build/cluster-node-tuning-operator/test/e2e/basic/default_irq_smp_affinity.go:82

Ran 5 of 8 Specs in 327.227 seconds
FAIL! -- 4 Passed | 1 Failed | 0 Pending | 3 Skipped
--- FAIL: TestNodeTuningOperator (327.23s)
FAIL
FAIL	github.com/openshift/cluster-node-tuning-operator/test/e2e/basic	327.242s
FAIL
make: *** [Makefile:91: test-e2e] Error 1

@jmencak
Copy link
Contributor Author

jmencak commented Nov 25, 2020

I'm having the same issues as Eduardo on OCP version 4.7.0-0.nightly:

There is no such a thing as 4.7.0-0.nightly. What's the exact version? You need a nightly that contains this: #179 It merged 6 days ago.

Ideally, you want to build your own custom image to test or trust ci/prow/e2e-aws-operator that runs all the e2e tests you're trying to run. As you can see, all the tests passed.

@jmencak
Copy link
Contributor Author

jmencak commented Nov 26, 2020

@courtneypacheco the current e2e tests (in this PR) work without any issues for me on 4.7.0-0.nightly-2020-11-25-114114 and with an NTO image built from this PR. Please make sure your installation is up-to-date.

@jmencak
Copy link
Contributor Author

jmencak commented Nov 26, 2020

/uncc @Deepthidharwar

@openshift-ci-robot openshift-ci-robot removed the request for review from Deepthidharwar November 26, 2020 11:22
@jmencak jmencak mentioned this pull request Nov 26, 2020
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch makes sense and add the described value

test/e2e/basic/available.go Show resolved Hide resolved
@courtneypacheco
Copy link

I'm having the same issues as Eduardo on OCP version 4.7.0-0.nightly:

There is no such a thing as 4.7.0-0.nightly. What's the exact version? You need a nightly that contains this: #179 It merged 6 days ago.

Ideally, you want to build your own custom image to test or trust ci/prow/e2e-aws-operator that runs all the e2e tests you're trying to run. As you can see, all the tests passed.

I see. My nightly didn't contain #179. I apologize.

I was able to test everything and it looks good to me now after running the e2e tests.

Copy link

@courtneypacheco courtneypacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: courtneypacheco, jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b5af40d into openshift:master Nov 30, 2020
@jmencak jmencak deleted the 4.7-e2e-cleanup branch December 1, 2020 06:49
@jmencak
Copy link
Contributor Author

jmencak commented Dec 1, 2020

Thank you for the review, @courtneypacheco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants