New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate manifests for single-node-developer cluster profile #185
Annotate manifests for single-node-developer cluster profile #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading openshift/enhancements#482
/lgtm
Thank you for the PR, @cfergeau . Only a minor nit. It would be great if the annotations could be in alphabetical order, but I can clean this up later. |
This partially implements phase 1 of https://github.com/openshift/enhancements#482 and does not change behavior. Initially, all cluster-node-tuning-operator manifests are included in the single-node-developer cluster profile. Follow-on PRs may exclude any of these that are not needed in the profile.
488112a
to
e0d3a6d
Compare
That's a fair point as I've been paying attention to this in other PRs, I missed that one. This is fixed now. |
Thanks again! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, cfergeau, jmencak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/uncc @kpouget |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
This partially implements phase 1 of https://github.com/openshift/enhancements#482
and does not change behavior. Initially, all cluster-node-tuning-operator
manifests are included in the single-node-developer cluster profile.
Follow-on PRs may exclude any of these that are not needed in the
profile.