Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1919970: Recover gracefully after Tuned errors. #196

Merged
merged 1 commit into from Jan 26, 2021

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Jan 26, 2021

Added an additional state to openshift-tuned "status" indicating whether Tuned profile application was successful or applied with warnings/errors. If it was applied with errors and a Profile change is detected, Tuned daemon is reloaded.

Added an additional state to openshift-tuned "status" indicating whether Tuned
profile application was successful or applied with warnings/errors.  If it was
applied with errors and a Profile change is detected, Tuned daemon is reloaded.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2021
@jmencak jmencak changed the title Recover gracefully after Tuned errors. Bug 1919970: Recover gracefully after Tuned errors. Jan 26, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 26, 2021
@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request references Bugzilla bug 1919970, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1919970: Recover gracefully after Tuned errors.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 26, 2021
@sjug
Copy link
Contributor

sjug commented Jan 26, 2021

/lgtm

Fun times with bits, thanks @jmencak !

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, sjug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2021
@openshift-merge-robot openshift-merge-robot merged commit d513673 into openshift:master Jan 26, 2021
@openshift-ci-robot
Copy link
Contributor

@jmencak: All pull requests linked via external trackers have merged:

Bugzilla bug 1919970 has been moved to the MODIFIED state.

In response to this:

Bug 1919970: Recover gracefully after Tuned errors.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants