Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1986477: Handle kube-apiserver disruption more gracefully. #256

Merged
merged 1 commit into from Jul 28, 2021
Merged

Bug 1986477: Handle kube-apiserver disruption more gracefully. #256

merged 1 commit into from Jul 28, 2021

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Jul 28, 2021

This PR increases leader-election timeouts as per the recommendation in:
https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md
to tolerate 60s worth of disruption.

Resolves rhbz#1986477.

@jmencak
Handle kube-apiserver disruption more gracefully.
6dd0bb0 
This PR increases leader-election timeouts as per the recommendation in:
https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md
to tolerate 60s worth of disruption.

Resolves rhbz#1986477.
@openshift-ci openshift-ci bot requested review from dagrayvid and kpouget July 28, 2021 13:23
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021
@jmencak jmencak changed the title Handle kube-apiserver disruption more gracefully. Bug 1986477: Handle kube-apiserver disruption more gracefully. Jul 28, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@jmencak: This pull request references Bugzilla bug 1986477, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (skordas@redhat.com), skipping review request.

In response to this:

Bug 1986477: Handle kube-apiserver disruption more gracefully.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor Author

jmencak commented Jul 28, 2021

/cc @chaitanyaenr

@openshift-ci openshift-ci bot requested a review from chaitanyaenr July 28, 2021 13:24
@dagrayvid
Copy link
Contributor

Interesting!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dagrayvid, jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmencak
Copy link
Contributor Author

jmencak commented Jul 28, 2021 •
edited

Tested on a regular cluster by disabling access to :6443. Seeing ~1 NTO restart for 120s, no NTO restarts for 60s.

@openshift-merge-robot openshift-merge-robot merged commit 7d791cd into openshift:master Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@jmencak: All pull requests linked via external trackers have merged:

Bugzilla bug 1986477 has been moved to the MODIFIED state.

In response to this:

Bug 1986477: Handle kube-apiserver disruption more gracefully.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak jmencak deleted the 4.9-bz1986477-lease-duration branch July 28, 2021 16:30
@jmencak
Copy link
Contributor Author

jmencak commented Jul 28, 2021

/cherry-pick release-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 28, 2021
Merged
@openshift-cherrypick-robot
Copy link

@jmencak: new pull request created: #257

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagrayvid dagrayvid Awaiting requested review from dagrayvid

@kpouget kpouget Awaiting requested review from kpouget

@chaitanyaenr chaitanyaenr Awaiting requested review from chaitanyaenr

Assignees

@dagrayvid dagrayvid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmencak @dagrayvid @openshift-cherrypick-robot @openshift-merge-robot