New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nto_custom_profiles:count metric via PrometheusRule #292
Add nto_custom_profiles:count metric via PrometheusRule #292
Conversation
/retest |
Thank you for the PR, David. This makes sense to me. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dagrayvid, jmencak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds a metric to count the number of custom Profiles in the cluster. Put another way, it counts the number of nodes that are using a TuneD profile other than
openshift-node
,openshift-control-plane
. andopenshift
.We can get this information from the existing
nto_profile_calculated_total
metric using the query:count(nto_profile_calculated_total{profile!~"openshift-node",profile!~"openshift-control-plane",profile!~"openshift"})
I was hoping to add this query directly to the telemetry rules, but it seems telemetry requires that metrics be specified by name only, so using this full query is not possible. Fortunately we can add a "new metric" just by using a PrometheusRule.
Once we get this added the PR to the cluster-monitoring-operator will be quite simple to add this metric to telemetry.