Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2073938: Replace RuntimeClass version from v1beta1 to v1 #342

Merged
merged 1 commit into from Apr 13, 2022

Conversation

yanirq
Copy link
Contributor

@yanirq yanirq commented Apr 12, 2022

RuntimeClass in the node.k8s.io/v1beta1 API version
will no longer be served in v1.25, therefore all occurrences in code containing v1beta1 are replaced with v1.
Kubernetes already supports the seamless transition for existing runtimeclasses.node.k8s.io v1beta1 to v1.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 12, 2022

@yanirq: This pull request references Bugzilla bug 2073938, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2073938: Replace RuntimeClass version from v1beta1 to v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2022
@yanirq
Copy link
Contributor Author

yanirq commented Apr 12, 2022

/cc @cynepco3hahue @MarSik

@yanirq
Copy link
Contributor Author

yanirq commented Apr 12, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 12, 2022

@yanirq: This pull request references Bugzilla bug 2073938, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (liqcui@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor

jmencak commented Apr 12, 2022

This is a straingforward s/// and this change looks good to me. Even the commit message looks mostly ok, so thank you for that. However, could we please keep the first letter of the commit message uppercase? I.e. s/replace/Replace/. Thank you!

@cynepco3hahue
Copy link
Contributor

@yanirq The change lgtm, can you please verify if it works correctly during the upgrade?

RuntimeClass in the node.k8s.io/v1beta1 API version
will no longer be served in v1.25, therefore all occurrences in code
containing v1beta1 are replaced with v1.
Kubernetes already supports the seamless transition for existing
runtimeclasses.node.k8s.io v1beta1 to v1.
@yanirq
Copy link
Contributor Author

yanirq commented Apr 12, 2022

@yanirq The change lgtm, can you please verify if it works correctly during the upgrade?

@cynepco3hahue I tested a 4.11 cluster with a runtime object defined as v1beta1 which immediately got replaced with v1.
After that I have deployed NTO with the current content, a performance profile that would match the existing runtime class and the relevant machine config pool to go with it without any issues.

@cynepco3hahue
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2022
Copy link
Contributor

@jlojosnegros jlojosnegros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlojosnegros, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 13, 2022

@yanirq: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1bdb98b into openshift:master Apr 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 13, 2022

@yanirq: All pull requests linked via external trackers have merged:

Bugzilla bug 2073938 has been moved to the MODIFIED state.

In response to this:

Bug 2073938: Replace RuntimeClass version from v1beta1 to v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request May 23, 2023
RuntimeClass in the node.k8s.io/v1beta1 API version
will no longer be served in v1.25, therefore all occurrences in code
containing v1beta1 are replaced with v1.
Kubernetes already supports the seamless transition for existing
runtimeclasses.node.k8s.io v1beta1 to v1.
IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request Jun 13, 2023
RuntimeClass in the node.k8s.io/v1beta1 API version
will no longer be served in v1.25, therefore all occurrences in code
containing v1beta1 are replaced with v1.
Kubernetes already supports the seamless transition for existing
runtimeclasses.node.k8s.io v1beta1 to v1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants