New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2073938: Replace RuntimeClass version from v1beta1 to v1 #342
Conversation
|
@yanirq: This pull request references Bugzilla bug 2073938, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@yanirq: This pull request references Bugzilla bug 2073938, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (liqcui@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This is a straingforward |
|
@yanirq The change lgtm, can you please verify if it works correctly during the upgrade? |
RuntimeClass in the node.k8s.io/v1beta1 API version will no longer be served in v1.25, therefore all occurrences in code containing v1beta1 are replaced with v1. Kubernetes already supports the seamless transition for existing runtimeclasses.node.k8s.io v1beta1 to v1.
@cynepco3hahue I tested a 4.11 cluster with a runtime object defined as v1beta1 which immediately got replaced with v1. |
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlojosnegros, yanirq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@yanirq: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@yanirq: All pull requests linked via external trackers have merged: Bugzilla bug 2073938 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
RuntimeClass in the node.k8s.io/v1beta1 API version will no longer be served in v1.25, therefore all occurrences in code containing v1beta1 are replaced with v1. Kubernetes already supports the seamless transition for existing runtimeclasses.node.k8s.io v1beta1 to v1.
RuntimeClass in the node.k8s.io/v1beta1 API version will no longer be served in v1.25, therefore all occurrences in code containing v1beta1 are replaced with v1. Kubernetes already supports the seamless transition for existing runtimeclasses.node.k8s.io v1beta1 to v1.
RuntimeClass in the node.k8s.io/v1beta1 API version
will no longer be served in v1.25, therefore all occurrences in code containing v1beta1 are replaced with v1.
Kubernetes already supports the seamless transition for existing runtimeclasses.node.k8s.io v1beta1 to v1.