Bug 2078969: Ignore Profile updates triggered by old operands

[jmencak]

Depending on TuneD configuration and version, TuneD may calculate
different kernel command-line parameters for the same TuneD profile.
This is a problem during NTO operator upgrades. The old (still running)
and newly started NTO operands (already running with newer version of
TuneD) will compete to push their specific version of calculated kernel
command-line parameters. The new version will always win, but this
"competition" may trigger extra unwanted node reboots.

This change prevents the operator from accepting the
MachineConfig-specific changes from old (not-yet-upgraded) operands.
This prevents the NTO-generated MachineConfigs from being flipped
between the old and new versions of kernel command-line parameters.

Other changes:

• Fix a potential SEGV when a Profile fails to be retrieved by the
  operand.

Resolves rhbz#2078969.

[openshift-ci]

@jmencak: This pull request references Bugzilla bug 2078969, which is invalid:

• expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2078969: Ignore Profile updates triggered by old operands

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jmencak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jmencak]

/bugzilla refresh

[openshift-ci]

@jmencak: This pull request references Bugzilla bug 2078969, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (liqcui@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jmencak]

/cc @dagrayvid
Additional info. I've noticed this issue yesterday when upgrading from 4.8->4.9 and using realtime profile (other upgrades up to 4.11 were fine). We need to get this backported to at least 4.9 (that will fix the 4.8->4.9 upgrade issue). Didn't see any issues from 4.7->4.8 upgrades, but ideally, I'd like to backport this to 4.8 too.

[openshift-ci]

@jmencak: This pull request references Bugzilla bug 2078969, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (liqcui@redhat.com), skipping review request.

In response to this:

Bug 2078969: Ignore Profile updates triggered by old operands

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jmencak]

Piggy-backing a fix (I know it is not ideal...) for a SEGV issue found by @fromanirh. Thank you for the report.

[jmencak]

/retest

[jmencak]

/retest

[jmencak]

Infra issues.

error: timed out waiting for the condition on clusteroperators/network

/joke
/retest

[openshift-ci]

@jmencak: I've been trying to come up with a dad joke about momentum . . . but I just can't seem to get it going.

In response to this:

Infra issues.

error: timed out waiting for the condition on clusteroperators/network

/joke
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jmencak]

/retest

[jmencak]

Infra issues Cluster operator monitoring is not available. I'm not going to and waste any more money on retesting until this is reviewed. @dagrayvid could you please take a look? Thank you!

[dagrayvid]

Thanks Jiri. These fixes looks good to me.

/lgtm

[jmencak]

Thank you David.
/retest

[jmencak]

Failed to wait for bootstrapping to complete. 

/retest

[jmencak]

/retest

[jmencak]

Bot, please give me a favour and once this merges
/cherry-pick release-4.10

[openshift-cherrypick-robot]

@jmencak: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

Bot, please give me a favour and once this merges
/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@jmencak: All pull requests linked via external trackers have merged:

• openshift/cluster-node-tuning-operator#355

Bugzilla bug 2078969 has been moved to the MODIFIED state.

In response to this:

Bug 2078969: Ignore Profile updates triggered by old operands

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@jmencak: #355 failed to apply on top of branch "release-4.10":

Applying: Ignore Profile updates triggered by old operands
Using index info to reconstruct a base tree...
M	pkg/apis/tuned/v1/tuned_types.go
M	pkg/operator/controller.go
M	pkg/tuned/controller.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/tuned/controller.go
Auto-merging pkg/operator/controller.go
CONFLICT (content): Merge conflict in pkg/operator/controller.go
Auto-merging pkg/apis/tuned/v1/tuned_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Ignore Profile updates triggered by old operands
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

Bot, please give me a favour and once this merges
/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.