Bug 2080123: Ignore Profile updates triggered by old operands #357
Conversation
Depending on TuneD configuration and version, TuneD may calculate
different kernel command-line parameters for the same TuneD profile.
This is a problem during NTO operator upgrades. The old (still running)
and newly started NTO operands (already running with newer version of
TuneD) will compete to push their specific version of calculated kernel
command-line parameters. The new version will always win, but this
"competition" may trigger extra unwanted node reboots.
This change prevents the operator from accepting the
MachineConfig-specific changes from old (not-yet-upgraded) operands.
This prevents the NTO-generated MachineConfigs from being flipped
between the old and new versions of kernel command-line parameters.
Other changes:
- Fix a potential SEGV when a Profile fails to be retrieved by the
operand.
Resolves rhbz#2080123.
openshift-ci
bot
added
bugzilla/severity-high
|
@jmencak: This pull request references Bugzilla bug 2080123, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
This is a "backport" of #355. The code is exactly the same, the |
|
As you already reviewed the fix for 4.11, could you please take a look, David? |
|
@jmencak: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Thanks @jmencak. Looks good /lgtm |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2080123, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2080123, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2080123, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2080123, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2080123, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2080123, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2080123, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
the
bugzilla/valid-bug
openshift-ci
bot
removed
the
bugzilla/invalid-bug
|
@jmencak: This pull request references Bugzilla bug 2080123, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (liqcui@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Backport risk assessment
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
|
@wabouhamad , can we please have cherry-pick-approved label? Thank you! |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@jmencak: All pull requests linked via external trackers have merged: Bugzilla bug 2080123 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Depending on TuneD configuration and version, TuneD may calculate
different kernel command-line parameters for the same TuneD profile.
This is a problem during NTO operator upgrades. The old (still running)
and newly started NTO operands (already running with newer version of
TuneD) will compete to push their specific version of calculated kernel
command-line parameters. The new version will always win, but this
"competition" may trigger extra unwanted node reboots.
This change prevents the operator from accepting the
MachineConfig-specific changes from old (not-yet-upgraded) operands.
This prevents the NTO-generated MachineConfigs from being flipped
between the old and new versions of kernel command-line parameters.
Other changes:
operand.
Resolves rhbz#2080123.