Bug 2083482: Ignore Profile updates triggered by old operands

[jmencak]

Depending on TuneD configuration and version, TuneD may calculate
different kernel command-line parameters for the same TuneD profile.
This is a problem during NTO operator upgrades. The old (still running)
and newly started NTO operands (already running with newer version of
TuneD) will compete to push their specific version of calculated kernel
command-line parameters. The new version will always win, but this
"competition" may trigger extra unwanted node reboots.

This change prevents the operator from accepting the
MachineConfig-specific changes from old (not-yet-upgraded) operands.
This prevents the NTO-generated MachineConfigs from being flipped
between the old and new versions of kernel command-line parameters.

Other changes:

• Fix a potential SEGV when a Profile fails to be retrieved by the
  operand.
• Simplify the e2e stalld test. It is unnecessarily complex and only
  adds to the time it takes to pass all e2e tests by approximately 1
  node reboot. Add more debugging for any future troubleshooting.

[openshift-ci]

@jmencak: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Ignore Profile updates triggered by old operands

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jmencak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jmencak: This pull request references Bugzilla bug 2083482, which is invalid:

• expected dependent Bugzilla bug 2080123 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2083482: Ignore Profile updates triggered by old operands

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jmencak]

/bugzilla refresh

[openshift-ci]

@jmencak: This pull request references Bugzilla bug 2083482, which is invalid:

• expected Bugzilla bug 2083482 to depend on a bug targeting a release in 4.10.0, 4.10.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jmencak]

/bugzilla refresh

[openshift-ci]

@jmencak: This pull request references Bugzilla bug 2083482, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2080123 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2080123 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (liqcui@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jmencak]

/assign @dagrayvid

[dagrayvid]

Thanks Jiri.

/lgtm

[jmencak]

Backport risk assessment

• If the Bugzilla associated with the PR has the "FastFix" keyword, the subjective assessment on the issue has already been done and a customer is impacted. These PRs should be prioritized for merge.
  • not applicable
• For branches that are in the Maintenance lifecycle phase:
  • not applicable
• The bug has significant impact either through severity, reduction in supportability, or number of users affected.
  • yes
• The severity field of the bug must be set to accurately reflect criticality.
  • bugzilla/severity-high
• The PR is merged in the next newer release branch and the bug for that newer release is VERIFIED by QE.
  • yes
• The PR’s description is well formed with user-focused release notes that state the bug number, impact, cause, and resolution. Where appropriate, it should also contain information about how a user can identify whether a particular cluster is affected.
  • yes

/label backport-risk-assessed

[jmencak]

@wabouhamad , can we please have cherry-pick-approved label? Thank you!

[wabouhamad]

/label cherry-pick-approved

[openshift-ci]

@jmencak: All pull requests linked via external trackers have merged:

• openshift/cluster-node-tuning-operator#361

Bugzilla bug 2083482 has been moved to the MODIFIED state.

In response to this:

Bug 2083482: Ignore Profile updates triggered by old operands

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jmencak]

Let's see if cherry-picking can deal with patch offsets
/cherry-pick release-4.8

[openshift-cherrypick-robot]

@jmencak: new pull request created: #364

In response to this:

Let's see if cherry-picking can deal with patch offsets
/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.