Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.1] Bug 1718842: Operator-assisted removal of detached tuned secrets. #65

Merged
merged 1 commit into from Jun 25, 2019
Merged

[release-4.1] Bug 1718842: Operator-assisted removal of detached tuned secrets. #65

merged 1 commit into from Jun 25, 2019

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #63

/assign jmencak

@jmencak
Operator-assisted removal of detached tuned secrets.
6f11090 
This commit adds support for automatic removal of detached tuned
secrets which might have accumulated in the operator namespace
prior to commit 014900f.

Associated BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1714484
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 11, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 11, 2019
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "---" instead

In response to this:

[release-4.1] Bug 1718842: Operator-assisted removal of detached tuned secrets.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 11, 2019
@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "---" instead

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor

jmencak commented Jun 11, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 11, 2019
@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request references a valid Bugzilla bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor

jmencak commented Jun 11, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2019
@derekwaynecarr
Copy link
Member

absent an automated test, need to wait for qe to verify the change in master works as intended.

@derekwaynecarr
Copy link
Member

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@derekwaynecarr: This pull request references a valid Bugzilla bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis
Copy link
Member

eparis commented Jun 24, 2019

There is no 4.2 bugzilla which tracks this issue nor is there any automated test which shows the safety of this change. The team should create/clone the existing 4.1.z bugzilla to 4.2 and get QA to move it to VERIFIED.

At this point this PR is not likely to make 4.1.4. Please address the bugzilla/testing issues as quickly as possible.

@jmencak
Copy link
Contributor

jmencak commented Jun 24, 2019 •
edited

There is no 4.2 bugzilla which tracks this issue nor is there any automated test which shows the safety of this change. The team should create/clone the existing 4.1.z bugzilla to 4.2 and get QA to move it to VERIFIED.

At this point this PR is not likely to make 4.1.4. Please address the bugzilla/testing issues as quickly as possible.

Cloned to 4.2 BZ1723569

@eparis eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 25, 2019
@jmencak
Copy link
Contributor

jmencak commented Jun 25, 2019

BZ1723569 is now VERIFIED by QE on 4.2.

@openshift-merge-robot openshift-merge-robot merged commit 275231b into openshift:release-4.1 Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmencak jmencak Awaiting requested review from jmencak

@sjug sjug Awaiting requested review from sjug

Assignees

@jmencak jmencak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @jmencak @derekwaynecarr @eparis @openshift-merge-robot