From 8d40c3eedbb851e08a9a6bf31f44d20d0669d0bf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jose=20Luis=20Ojosnegros=20Manch=C3=B3n?= Date: Fri, 21 Jul 2023 16:47:52 +0200 Subject: [PATCH] Improve render error handling When looking for a MachineConfigPool match for each PerformanceProfile we can found no match at all. We should check for this case before using the MCP. This do not detect the root cause of the problem, an invalid PerformanceProfile. To tackle that problem we would need something more deep like a validator. --- pkg/performanceprofile/cmd/render/render.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkg/performanceprofile/cmd/render/render.go b/pkg/performanceprofile/cmd/render/render.go index e871fe832..fa3a8033a 100644 --- a/pkg/performanceprofile/cmd/render/render.go +++ b/pkg/performanceprofile/cmd/render/render.go @@ -156,6 +156,11 @@ func render(inputDir, outputDir string) error { return err } + if mcp == nil { + klog.Infof("render: No MachineConfigPool found for PerformanceProfile %s", pp.Name) + continue + } + defaultRuntime, err := getContainerRuntimeName(pp, mcp, ctrcfgs) if err != nil { return fmt.Errorf("render: could not determine high-performance runtime class container-runtime for profile %q; %w", pp.Name, err)