-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug 1804717: Cleanup switch to managing openshift-apiserver pods with a deployment #324
bug 1804717: Cleanup switch to managing openshift-apiserver pods with a deployment #324
Conversation
@marun: This pull request references Bugzilla bug 1804717, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@marun: This pull request references Bugzilla bug 1804717, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b08de3a
to
21d042b
Compare
/retest |
@@ -85,6 +94,17 @@ func NewWorkloadController( | |||
queue: workqueue.NewNamedRateLimitingQueue(workqueue.DefaultControllerRateLimiter(), "OpenShiftAPIServerOperator"), | |||
} | |||
|
|||
// This function supports determining the number of master nodes | |||
// to allow setting the deployment replica count to match. | |||
c.countNodes = func(nodeSelector map[string]string) (*int32, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too big for an anonymous function. Make this an actual function on the OpenshfitAPIServerOperator
. Then assign this function to countNodes
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
/lgtm hold for the factorization update. |
21d042b
to
86a2f1d
Compare
/hold cancel if this causes multiple rollouts, we may have to reconsider, but it seems like a reasonable way to be flexible for now. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, marun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@marun: All pull requests linked via external trackers have merged. Bugzilla bug 1804717 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR addresses comments and otherwise unresolved issues from #313
previousGeneration
label from the deploymentcc: @deads2k @sttts @tnozicka