Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1808568: Fix rollout strategy to never run more than one pod per node #331

Merged
merged 2 commits into from Mar 6, 2020

Conversation

marun
Copy link
Contributor

@marun marun commented Mar 6, 2020

Update the deployment rollout strategy to never allow more than one pod to run at a time on a given master node. This change removes the need to set an anti-affinity uuid label since the previous replica set's pod must be turned down before a new one can be scheduled.

The previous rollout strategy allowed more than one pod per node to run on a given master node during rollout. This was a break from the rollout strategy used by the daemonset controller, where each node had its pod turned down before another could start. The daemonset behavior must be maintained to ensure coherent audit logs.

@openshift-ci-robot
Copy link

@marun: This pull request references Bugzilla bug 1808568, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1808568: Fix rollout strategy to never run more than one pod per node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2020
@marun marun changed the title Bug 1808568: Fix rollout strategy to never run more than one pod per node WIP Bug 1808568: Fix rollout strategy to never run more than one pod per node Mar 6, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2020
Update the deployment rollout strategy to never allow more than one
pod to run at a time on a given master node. This change removes the
need to set an anti-affinity uuid label since the previous replica
set's pod must be turned down before a new one can be scheduled.

The previous rollout strategy allowed more than one pod per node to
run on a given master node during rollout. This was a break from the
rollout strategy used by the daemonset controller, where each node had
its pod turned down before another could start. The daemonset behavior
must be maintained to ensure coherent audit logs.
@deads2k
Copy link
Contributor

deads2k commented Mar 6, 2020

/retest

@deads2k
Copy link
Contributor

deads2k commented Mar 6, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, marun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020
@marun marun changed the title WIP Bug 1808568: Fix rollout strategy to never run more than one pod per node Bug 1808568: Fix rollout strategy to never run more than one pod per node Mar 6, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2020
@openshift-merge-robot openshift-merge-robot merged commit 6daf596 into openshift:master Mar 6, 2020
@marun marun deleted the pod-per-node branch March 6, 2020 18:15
@sttts
Copy link
Contributor

sttts commented Mar 9, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot

@sttts: new pull request created: #332

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants