New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1808568: Fix rollout strategy to never run more than one pod per node #331
Conversation
@marun: This pull request references Bugzilla bug 1808568, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update the deployment rollout strategy to never allow more than one pod to run at a time on a given master node. This change removes the need to set an anti-affinity uuid label since the previous replica set's pod must be turned down before a new one can be scheduled. The previous rollout strategy allowed more than one pod per node to run on a given master node during rollout. This was a break from the rollout strategy used by the daemonset controller, where each node had its pod turned down before another could start. The daemonset behavior must be maintained to ensure coherent audit logs.
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, marun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.4 |
@sttts: new pull request created: #332 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update the deployment rollout strategy to never allow more than one pod to run at a time on a given master node. This change removes the need to set an anti-affinity uuid label since the previous replica set's pod must be turned down before a new one can be scheduled.
The previous rollout strategy allowed more than one pod per node to run on a given master node during rollout. This was a break from the rollout strategy used by the daemonset controller, where each node had its pod turned down before another could start. The daemonset behavior must be maintained to ensure coherent audit logs.