Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1840857: openshift-apiserver doesn't live reload extension-apiserver-authentication trust #366

Conversation

p0lyn0mial
Copy link
Contributor

reverts waiting for requestheader-client-ca-file in extension-apiserver-authentication before rolling out a new version.

it is replaced by openshift/openshift-apiserver#103 which essentially shifts the logic to API Servers. From now on a server watches and reacts to changes in the config map in real-time.

…-authentication before rolling out a new version"

This reverts commit 33ce8df.
@openshift-ci-robot
Copy link

@p0lyn0mial: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Revert "waits for requestheader-client-ca-file in extension-apiserver…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@p0lyn0mial p0lyn0mial changed the title Revert "waits for requestheader-client-ca-file in extension-apiserver… Bug 1840857: openshift-apiserver doesn't live reload extension-apiserver-authentication trust May 28, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label May 28, 2020
@openshift-ci-robot
Copy link

@p0lyn0mial: This pull request references Bugzilla bug 1840857, which is invalid:

  • expected dependent Bugzilla bug 1840856 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1840857: openshift-apiserver doesn't live reload extension-apiserver-authentication trust

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 28, 2020
@p0lyn0mial
Copy link
Contributor Author

/assigns @sttts

@sttts
Copy link
Contributor

sttts commented May 28, 2020

/lgtm
/approve
/hold

waiting for openshift/openshift-apiserver#103. Unhold when ready.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@mfojtik
Copy link
Member

mfojtik commented Jun 3, 2020

@sttts @p0lyn0mial i tagged the pre-req can you make the test green?

@mfojtik
Copy link
Member

mfojtik commented Jun 3, 2020

/retest
/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 3, 2020
@openshift-ci-robot
Copy link

@mfojtik: This pull request references Bugzilla bug 1840857, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1840856 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1840856 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents

In response to this:

/retest
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member

mfojtik commented Jun 4, 2020

/retest

@p0lyn0mial
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2020
@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 4, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2786635 into openshift:release-4.4 Jun 4, 2020
@openshift-ci-robot
Copy link

@p0lyn0mial: All pull requests linked via external trackers have merged: openshift/openshift-apiserver#103, openshift/cluster-openshift-apiserver-operator#366. Bugzilla bug 1840857 has been moved to the MODIFIED state.

In response to this:

Bug 1840857: openshift-apiserver doesn't live reload extension-apiserver-authentication trust

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants