Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates encryption related components so that CAO can start manage its own encryption configuration #416

Merged
merged 4 commits into from Dec 3, 2020
Merged

updates encryption related components so that CAO can start manage its own encryption configuration #416

merged 4 commits into from Dec 3, 2020

Conversation

p0lyn0mial
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2020
@p0lyn0mial p0lyn0mial force-pushed the cao-manages-encryption-cfg branch 3 times, most recently from 09b9dc8 to 44263fa Compare November 18, 2020 14:02
@p0lyn0mial
Copy link
Contributor Author

/assign @sttts

@p0lyn0mial p0lyn0mial changed the title WIP: cao encryption config updates encryption related components so that CAO can start manage its own encryption configuration Nov 23, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2020
@p0lyn0mial
Copy link
Contributor Author

/hold

for manual testing

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2020
@p0lyn0mial
Copy link
Contributor Author

/retest

sttts
sttts reviewed Nov 24, 2020
View reviewed changes
pkg/operator/encryptionprovider/encryptionprovider_test.go Outdated
expectedEncryptedGRs: defaultGRs,
// this is default in 4.7
name: "encryption off, only OAS GRs are returned",
defaultEncryptedGRs: allGRs,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are defaultEncryptedGRs even used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaultEncryptedGRs is actually allEncryptedGRs - this list will be reduced once we remove the annotations. So on an upgrade 4.6 to 4.7 it will be reduced to GRs hosted by OAS

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2020
@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws-operator-encryption

@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws-operator-encryption

@p0lyn0mial
Copy link
Contributor Author

/retest

@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws-operator-encryption

@sttts
Copy link
Contributor

sttts commented Dec 2, 2020

/retest
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 2, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@p0lyn0mial
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2020
@p0lyn0mial
Copy link
Contributor Author

e2e-aws-operator-encryption-perf will be removed by openshift/release#14004

@sttts
Copy link
Contributor

sttts commented Dec 2, 2020

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws

1 similar comment
@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws

@mfojtik
Copy link
Member

mfojtik commented Dec 3, 2020

/override ci/prow/e2e-aws-operator-encryption-perf

@openshift-ci-robot
Copy link

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-aws-operator-encryption-perf

In response to this:

/override ci/prow/e2e-aws-operator-encryption-perf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik mfojtik merged commit ad75456 into openshift:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@mfojtik mfojtik Awaiting requested review from mfojtik

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@p0lyn0mial @sttts @openshift-ci-robot @openshift-bot @mfojtik