Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1912820: competing connectivitycheckcontrollers cause pod restarts during upgrades #430

Merged
merged 2 commits into from Feb 8, 2021
Merged

Bug 1912820: competing connectivitycheckcontrollers cause pod restarts during upgrades #430

merged 2 commits into from Feb 8, 2021

Conversation

sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Feb 4, 2021 •
edited

pickup library-go#987

@sanchezl sanchezl changed the title connectivitycheckcontroller upgrade proof: for openshift/library-go#987 Feb 4, 2021
@sanchezl sanchezl force-pushed the connectivitycheckcontroller-upgrade branch 5 times, most recently from 4b4d912 to d9a5e1a Compare February 4, 2021 23:42
@sanchezl
Copy link
Contributor Author

sanchezl commented Feb 5, 2021

/test e2e-aws
/test e2e-upgrade

@sanchezl sanchezl changed the title proof: for openshift/library-go#987 Bug 1912820: competing connectivitycheckcontrollers cause pod restarts during upgrades Feb 5, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Feb 5, 2021
@openshift-ci-robot
Copy link

@sanchezl: This pull request references Bugzilla bug 1912820, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1912820: competing connectivitycheckcontrollers cause pod restarts during upgrades

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 5, 2021
@openshift-ci-robot
Copy link

@sanchezl: This pull request references Bugzilla bug 1912820, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1912820: competing connectivitycheckcontrollers cause pod restarts during upgrades

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanchezl
bump(*)
2d04cac 
library-go connectivitycheckcontroller
@sanchezl
react to openshift/library-go#987
f89260b
@sanchezl sanchezl force-pushed the connectivitycheckcontroller-upgrade branch from d9a5e1a to f89260b Compare February 5, 2021 20:52
@sanchezl
Copy link
Contributor Author

sanchezl commented Feb 6, 2021

/retest

@deads2k
Copy link
Contributor

deads2k commented Feb 8, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f56bdce into openshift:master Feb 8, 2021
@openshift-ci-robot
Copy link

@sanchezl: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1912820 has not been moved to the MODIFIED state.

In response to this:

Bug 1912820: competing connectivitycheckcontrollers cause pod restarts during upgrades

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 7, 2021

/cherry-pick release-4.7

@openshift-cherrypick-robot
Copy link

@sanchezl: new pull request created: #444

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sttts sttts Awaiting requested review from sttts

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sanchezl @openshift-ci-robot @deads2k @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot