New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1982726: encryption-controller: sync secrets conditionally #483
Bug 1982726: encryption-controller: sync secrets conditionally #483
Conversation
@dgrisonnet: This pull request references Bugzilla bug 1982726, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dgrisonnet: This pull request references Bugzilla bug 1982726, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @p0lyn0mial |
@dgrisonnet could you please split the PR into at least 2 commits? The first for bumping the dependency and the second for showing the changes to this repository. Easier to review. |
962c7d8
to
7254bf1
Compare
done @p0lyn0mial |
could you check where does the following panic come from? (in https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-openshift-apiserver-operator/483/pull-ci-openshift-cluster-openshift-apiserver-operator-master-e2e-aws/1460642187745169408)
|
could you also rename the first commit to |
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
Update the version of library-go to include the latest changes that allow the encryption controller to synchronize the encryption-config secret only when the encryption controller should be run. This prevents the secrets from being unnecessarily deleted in the apiserver namespace whenever it doesn't exist in the config-managed namespace. Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
7254bf1
to
421df2c
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dgrisonnet: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1982726 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update the version of library-go to include the latest changes that
allow the encryption controller to synchronize the encryption-config
secret only when the encryption controller should be run. This prevents
the secrets from being unnecessarily deleted in the apiserver namespace
whenever it doesn't exist in the config-managed namespace.
Follow-up to openshift/library-go#1243