Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1813233: Bumping github.com/openshift/library-go #148

Closed
wants to merge 1 commit into from
Closed

Bug 1813233: Bumping github.com/openshift/library-go #148

wants to merge 1 commit into from

Conversation

ricardomaraschini
Copy link
Contributor

By bumping library-go we now bind to "tcp" network type instead of
"tcp4" as before.

This is needed in order to correctly bind our http servers on ipv6
clusters.

By bumping library-go we now bind to "tcp" network type instead of
"tcp4" as before.

This is needed in order to correctly bind our http servers on ipv6
clusters.
@openshift-ci-robot
Copy link
Contributor

@ricardomaraschini: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bumping github.com/openshift/library-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ricardomaraschini
To complete the pull request process, please assign adambkaplan
You can assign the PR to them by writing /assign @adambkaplan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ricardomaraschini ricardomaraschini changed the title Bumping github.com/openshift/library-go Bug 1813233: Bumping github.com/openshift/library-go Apr 6, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 6, 2020
@openshift-ci-robot
Copy link
Contributor

@ricardomaraschini: This pull request references Bugzilla bug 1813233, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.5.0" instead
  • expected Bugzilla bug 1813233 to depend on a bug targeting the "4.4.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1813233: Bumping github.com/openshift/library-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricardomaraschini
Copy link
Contributor Author

/hold

Until I discovered how to better tackle this.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2020
@ricardomaraschini
Copy link
Contributor Author

No ipv6 support on 4.3 so this is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants