Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2110715: Set openshift.io/run-level to nil in openshift-controller-manager namespace #249

Merged
merged 1 commit into from Jul 26, 2022
Merged

Bug 2110715: Set openshift.io/run-level to nil in openshift-controller-manager namespace #249

merged 1 commit into from Jul 26, 2022

Conversation

LalatenduMohanty
Copy link
Member

Backport of #248

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2022

@LalatenduMohanty: This pull request references Bugzilla bug 2110715, which is invalid:

  • expected dependent Bugzilla bug 2110629 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2110715: Set openshift.io/run-level to nil in openshift-controller-manager namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LalatenduMohanty
Bug 2110629: Set openshift.io/run-level to nil in openshift-controlle…
a782337 
…r-manager namespace

The run-level was removed in openshift@d12a6ff
But because how the cluster-version operator reconciles manifest labels,
 dropping a label from the manifest does not remove it from the in-cluster resource
 when old clusters are updated into the new manifest.
This commit uses the approach the cluster-version operator used to drop its run-level,
 by setting the value to an empty string, which the run-level-consuming code treats identically to an unset label.

This avoids errors about:

...container has runAsNonRoot and image will run as root...

when updating to 4.11.

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@bparees bparees added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jul 25, 2022
@LalatenduMohanty
Copy link
Member Author

/test e2e-upgrade

@LalatenduMohanty
Copy link
Member Author

/test openshift-e2e-aws-builds-techpreview

1 similar comment
@LalatenduMohanty
Copy link
Member Author

/test openshift-e2e-aws-builds-techpreview

soltysh
soltysh approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@sdodson sdodson added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 26, 2022
@sdodson
Copy link
Member

sdodson commented Jul 26, 2022

/refresh

@openshift-merge-robot openshift-merge-robot merged commit 0315835 into openshift:release-4.11 Jul 26, 2022
7 of 8 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2022

@LalatenduMohanty: All pull requests linked via external trackers have merged:

Bugzilla bug 2110715 has been moved to the MODIFIED state.

In response to this:

Bug 2110715: Set openshift.io/run-level to nil in openshift-controller-manager namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2022

@LalatenduMohanty: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LalatenduMohanty @sdodson @soltysh @bparees @openshift-merge-robot