Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2111979: Set openshift.io/run-level to nil in openshift-controller-manager nam… #269

Merged
merged 1 commit into from Nov 7, 2022

Conversation

jkhelil
Copy link
Contributor

@jkhelil jkhelil commented Nov 4, 2022

…espace

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2022

@jkhelil: This pull request references Bugzilla bug 2111979, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jitendar-singh

In response to this:

Bug 2111979: Set openshift.io/run-level to nil in openshift-controller-manager nam…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coreydaley
Copy link
Member

/retest-required

@jkhelil
Copy link
Contributor Author

jkhelil commented Nov 7, 2022

/test e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2022

@jkhelil: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jkhelil
Copy link
Contributor Author

jkhelil commented Nov 7, 2022

/assign @gabemontero

@jkhelil
Copy link
Contributor Author

jkhelil commented Nov 7, 2022

/assign @adambkaplan

@gabemontero
Copy link
Contributor

/assign @coreydaley

@jkhelil Corey is an approver in the owners file, so he can apply the approve label. Neither Adam no I are approvers in the owners file.

FWIW I have no familiarity with the run-level label, so have no expertise to lend to this change.

@gabemontero gabemontero removed their assignment Nov 7, 2022
@coreydaley
Copy link
Member

/approve
/assign @bparees
for lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@bparees
Copy link
Contributor

bparees commented Nov 7, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, coreydaley, jkhelil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f494cc0 into openshift:master Nov 7, 2022
8 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2022

@jkhelil: All pull requests linked via external trackers have merged:

Bugzilla bug 2111979 has been moved to the MODIFIED state.

In response to this:

Bug 2111979: Set openshift.io/run-level to nil in openshift-controller-manager nam…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants