Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump(*) to v1.19.0-rc.3 #312

Merged
merged 1 commit into from Aug 5, 2020

Conversation

gabemontero
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2020
k8s.io/client-go v0.18.0
k8s.io/api v0.19.0-rc.3
k8s.io/apimachinery v0.19.0-rc.3
k8s.io/apiserver v0.19.0-rc.3 // indirect
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because of changes in openshift/library-go, we have to explicitly note k8s.io/apiserver in order for go mod vendor to work.

@coreydaley
Copy link
Member

/retest

@gabemontero
Copy link
Contributor Author

e2e failures unrelated to samples or samples operator

/retest

@gabemontero
Copy link
Contributor Author

ok all green tests @adambkaplan @coreydaley for the sample operator 1.19 rebase

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

think we just need a BZ on this to merge.

golang.org/x/sys/unix
golang.org/x/sys/windows
# golang.org/x/text v0.3.2
# golang.org/x/text v0.3.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this bumps golang.org/x/text, thereby fixing CVE-2020-14040 (not sure if we have a BZ for the samples operator on this one).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @adambkaplan

we do have a BZ and I've associated this PR with it, though through the BZ UI vs. marking this PR ... was planning on moving that BZ to MODIFIED manually if need be once this PR merged

could pivot on that and use that BZ here with this PR if we want ... I'm fine either way

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adambkaplan,gabemontero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabemontero
Copy link
Contributor Author

/test unit

@openshift-merge-robot openshift-merge-robot merged commit ccb3d26 into openshift:master Aug 5, 2020
@gabemontero gabemontero deleted the rebase-19 branch August 5, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants