New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump(*) to v1.19.0-rc.3 #312
Conversation
k8s.io/client-go v0.18.0 | ||
k8s.io/api v0.19.0-rc.3 | ||
k8s.io/apimachinery v0.19.0-rc.3 | ||
k8s.io/apiserver v0.19.0-rc.3 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because of changes in openshift/library-go, we have to explicitly note k8s.io/apiserver in order for go mod vendor
to work.
/retest |
e2e failures unrelated to samples or samples operator /retest |
ok all green tests @adambkaplan @coreydaley for the sample operator 1.19 rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
think we just need a BZ on this to merge.
golang.org/x/sys/unix | ||
golang.org/x/sys/windows | ||
# golang.org/x/text v0.3.2 | ||
# golang.org/x/text v0.3.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this bumps golang.org/x/text, thereby fixing CVE-2020-14040 (not sure if we have a BZ for the samples operator on this one).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @adambkaplan
we do have a BZ and I've associated this PR with it, though through the BZ UI vs. marking this PR ... was planning on moving that BZ to MODIFIED manually if need be once this PR merged
could pivot on that and use that BZ here with this PR if we want ... I'm fine either way
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test unit |
/assign @adambkaplan
fyi @coreydaley @otaviof