Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2002368: acccount for image api returning invalid on imagestream create based on allowed/blocked registry settings #394

Conversation

gabemontero
Copy link
Contributor

@gabemontero gabemontero commented Sep 8, 2021

Fixes #385

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2021

@gabemontero: This pull request references Bugzilla bug 2002368, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2002368: acccount for image api returning invalid on imagestream create based on allowed/blocked registry settings

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 8, 2021
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@gabemontero
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2021

@gabemontero: This pull request references Bugzilla bug 2002368, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jitendar-singh

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 8, 2021
@gabemontero
Copy link
Contributor Author

/hold

I can get a bit more sophisticated / robust with this.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2021
@gabemontero
Copy link
Contributor Author

/retest

@gabemontero gabemontero changed the title Bug 2002368: acccount for image api returning invalid on imagestream create based on allowed/blocked registry settings WIP: Bug 2002368: acccount for image api returning invalid on imagestream create based on allowed/blocked registry settings Sep 10, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2021
@gabemontero
Copy link
Contributor Author

aws flake

/test e2e-aws-upgrade

Copy link
Contributor

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2021
@gabemontero
Copy link
Contributor Author

yeah I'm going to pivot from our prior conversations @dperaza4dustbit

I'm going to watch allowed/blocked registries, and if we are blocked, I'm going to bootstrap as removed, similar to what we do with ipv6/proxy/disconnected .... a "separate cluster config" situation makes samples install untenable.

I'll add a new reason code when we are removed, and I believe the existing alert we have there should be sufficient.

With that, I don't think there would be any future work for you team to do wrt new metrics and alerts.

This will require a doc update with @rolfedh (which I just mentioned in scrum with him). We'll need to work with him here in this PR, perhaps with a Jira on his board, to track.

/assign @rolfedh

@@ -175,7 +175,7 @@ func (h *Handler) upsertImageStream(imagestreamInOperatorImage, imagestreamInClu
// return the error so the caller can decide what to do
return err
}
if IsRetryableAPIError(err) || kerrors.IsConflict(err) {
if ShouldNotGoDegraded(err) {
logrus.Printf("CRDUPDATE: retryable error %s with imagestream update %s", err.Error(), imagestreamInCluster.Name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pre-existing problem but this line causes panics, imagestreamInCluster is guaranteed to be nil (line 170 checks)

https://bugzilla.redhat.com/show_bug.cgi?id=2003683

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for heads up @stbenjam ... I've added a commit in this PR for now, but have also pinged @dperaza4dustbit about this

we'll either address here with that commit , or he can do a separate PR, based on his taking ownership of samples (we are in the middle of the transition this week).

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2021
@gabemontero gabemontero changed the title WIP: Bug 2002368: acccount for image api returning invalid on imagestream create based on allowed/blocked registry settings Bug 2002368: acccount for image api returning invalid on imagestream create based on allowed/blocked registry settings Sep 13, 2021
@gabemontero
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 13, 2021
@gabemontero
Copy link
Contributor Author

/hold

the new global image config check needs some work

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2021
@gabemontero
Copy link
Contributor Author

updated I did make are in separate commits for now @coreydaley .... I'll squash after you sign off on those, plus we sort out remaining questions

also, ideally we do not merge until I hear again from @dperaza4dustbit on these more recent changes ... he lgtmed an earlier version

@gabemontero
Copy link
Contributor Author

don't know why I couldn't find "errors" before ... switch will be up momentarily @coreydaley

@gabemontero
Copy link
Contributor Author

round 2 updates up @coreydaley

@gabemontero
Copy link
Contributor Author

known unit flake with okd version .. all other okd's passed

/skip

/retest

@gabemontero
Copy link
Contributor Author

/retest

@coreydaley
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2021
…reation

- on initial startup, as part of tbr check, bootstrap as removed
- if the samples registry has been overridden, mark config invalid with new reason code
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2021
@gabemontero
Copy link
Contributor Author

great thanks @coreydaley @dperaza4dustbit

I've squashed the review commits from @coreydaley 's reviews

if I could get one more lgtm from one of you, we'll go from there

about to ping @rolfedh on slack now to get the doc updates going

@coreydaley
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, dperaza4dustbit, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dperaza4dustbit,gabemontero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor Author

unrelated flakes in okd build test failure; sig-builds passed

/skip

@gabemontero
Copy link
Contributor Author

unrelated sig-instrumentation flake image eco

/test e2e-aws-image-ecosystem

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

@gabemontero: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws-jenkins de7179f link /test okd-e2e-aws-jenkins
ci/prow/okd-e2e-aws-builds de7179f link /test okd-e2e-aws-builds
ci/prow/okd-e2e-aws-upgrade de7179f link /test okd-e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8c0e76d into openshift:master Sep 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

@gabemontero: All pull requests linked via external trackers have merged:

Bugzilla bug 2002368 has been moved to the MODIFIED state.

In response to this:

Bug 2002368: acccount for image api returning invalid on imagestream create based on allowed/blocked registry settings

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the handle-allowed-registries-block branch September 15, 2021 18:00
@gabemontero
Copy link
Contributor Author

when it is time to cherrypick, the 4.9 and other z streams will need both this PR and #397

@gabemontero
Copy link
Contributor Author

/assign @jitendar-singh

ideally you apply the qe approved label to this PR

/assign @rolfedh

ideally you apply the docs approved label to this PR, where the input I gave you at https://docs.google.com/document/d/1fN_-2_ZPC6DQBIYJkrlqL_0i9GSVbqJ8YyhB8hRns-o/edit is the starting point you need

@jitendar-singh
Copy link

/label qe-approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster-samples-operator and stuck upgrade from 4.6 to 4.7 with restricted networks
8 participants