New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2006947: fix proxy portion of tbr inaccessible check #397
Conversation
@gabemontero: This pull request references Bugzilla bug 2006947, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@gabemontero: This pull request references Bugzilla bug 2006947, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@gabemontero: This pull request references Bugzilla bug 2006947, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
abbc3a8
to
485d8de
Compare
/hold until e2e-aws-proxy is available |
hard to tell ... probably a mysql flake in image eco give it passed earlier today and I see no recent commits there or in cakephp non related flakes in okd /skip |
/retest |
and we have a e2e-aws-proxy up and running |
aws fail on image ecosystem |
/test e2e-aws-image-ecosystem |
ok the e2e-aws-proxy failure was an unrelated sig-arch failure @adambkaplan @coreydaley all the sig-builds tests passed samples come up as managed, no image import failures, and the pod logs indicated the expected behavior this one is ready for any final review comments and tag for merge |
I'll /retest one more time to see if we get a total green, no unrelated flakes e2e-aws-proxy; otherwise I'll skip to facilitate merge |
low level install fail /retest |
/assign @dperaza4dustbit fyi - my last fix prior to ownership transfer broke OCP with proxy enabled .... this fixes it (the e2e-aws-proxy failures have been unrelated to this bug/fix, and I was able to verify in the must gather artifacts that samples was bootstrapping again as managed with proxy enabled as it should, where as the bug I introduced resulted in samples bootstrapping as removed). |
}) | ||
if err != nil { | ||
|
||
if len(proxy.Status.HTTPSProxy) > 0 || len(proxy.Status.HTTPProxy) > 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any chance that proxy.Status
could be nil here? Or are we confident that h.configclient.Proxies.Get
will provide that even if there is an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope it is not a pointer ... no nil ref issues here
pkg/stub/handler.go
Outdated
|
||
proxy := &configv1.Proxy{} | ||
var err error | ||
wait.PollImmediate(5*time.Second, 20*time.Second, func() (bool, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be worth at least logging the timeout error from this showing that it never completed.
err := wait.PollImmediate(5*time.Second, 20*time.Second, func() (bool, error) { | ||
|
||
proxy := &configv1.Proxy{} | ||
var err error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: The error from inside of the wait.pollImmediate
is never surfaced outside of that function, so this probably isn't needed here (but is for the second one below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually no with what I am doing with proxy I either need to do this as I have it, or I have to rename the var
leaving this as is
485d8de
to
17b783a
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coreydaley, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/skip |
/retest |
@gabemontero: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
/hold cancel |
/bugzilla refresh |
@gabemontero: This pull request references Bugzilla bug 2006947, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gabemontero: All pull requests linked via external trackers have merged: Bugzilla bug 2006947 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.