New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2015635: Remove Azure Stack Hub detection. #228
Bug 2015635: Remove Azure Stack Hub detection. #228
Conversation
Azure Disk CSI driver is installed by default, both on Azure cloud and Azure stack. We don't need to distinguish these two platform any longer. As side effect, this will stop installing Azure File CSI driver operator on Azure Stack Hub. It should be installed via TechPreviewNoUpgrade there too.
@jsafrane: This pull request references Bugzilla bug 2015635, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@jsafrane: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@jsafrane: All pull requests linked via external trackers have merged: Bugzilla bug 2015635 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Azure Disk CSI driver is installed by default, both on Azure cloud and Azure stack. We don't need to distinguish these two platform any longer.
As side effect, this will stop installing Azure File CSI driver operator on Azure Stack Hub. It should be installed via TechPreviewNoUpgrade there too.
This reverts PR #200.
cc @openshift/storage