Implement STOR-213 - Default Encryption for GP2 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
what is osd, dedicated? openshift-ansible defaulted to encrypted: false. https://github.com/openshift/openshift-ansible/blob/release-3.11/roles/openshift_default_storage_class/defaults/main.yml#L12 |
|
Yes. Dedicated. They were changing after install for new customers. I would
expect most others would as well.
In addition, we use encrypted AMIs now in AWS via the OCP 4.1 installer.
This change ensures additional EBS volumes default to encrypted as well.
|
|
OK, sgtm, let's get this change in before code freeze then... Please run |
openshift-ci-robot
added
the
approved
In 3.x, PV encryption is enabled by default in the gp2 storage class. On a recent OCP 4.1 install, I see that the default storage class does not have it enabled:
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
name: gp2
...
annotations:
storageclass.kubernetes.io/is-default-class: 'true'
ownerReferences:
...
provisioner: kubernetes.io/aws-ebs
parameters:
type: gp2
reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer
|
Pushed the bin change as well. Thanks! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cuppett, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closed
gnufied
pushed a commit
to gnufied/cluster-storage-operator
that referenced
this pull request
Dec 4, 2019
Encrypting Data at Datastore Layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3.x, PV encryption is enabled by default in the gp2 storage class. On a recent OCP 4.1 install, I see that the default storage class does not have it enabled:
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
name: gp2
...
annotations:
storageclass.kubernetes.io/is-default-class: 'true'
ownerReferences:
...
provisioner: kubernetes.io/aws-ebs
parameters:
type: gp2
reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer
We would like to see this default storage class be encrypted by default to mirror the behavior of OSD 3.x clusters.