Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AWS EBS volume expansion by default #34

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@cblecker
Copy link
Member

commented May 12, 2019

Add the allowVolumeExamsion option to to the default gp2 storage class, allowing for volumes to be expanded automatically after they are created.

https://docs.openshift.com/container-platform/4.1/storage/expanding-persistent-volumes.html

Enable AWS EBS volume expansion by default
Add the allowVolumeExamsion option to the default gp2 storage class,
allowing for volumes to be expanded automatically after they are
created.
@openshift-ci-robot

This comment has been minimized.

Copy link

commented May 12, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cblecker
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tsmetana

If they are not already assigned, you can assign the PR to them by writing /assign @tsmetana in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bertinatto

This comment has been minimized.

Copy link
Member

commented May 13, 2019

I suppose we don't add the volume expansion to the standard storage class because the feature is beta in 4.1. What do you think, @gnufied?

@gnufied

This comment has been minimized.

Copy link
Member

commented May 13, 2019

so far the reasoning for not enabling resizing in default storageclass wasn't because feature was in beta but because for AWS in particular, the volume resizing quota is pretty low. Like you can only resize same volume every 6 minutes or something. I dunno what the global quota looks like, but I would assume it would be pretty low too.

Enabling it in deault SC will allow all users tor resize their PVCs. @cblecker is that what we want?

@cblecker

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

@gnufied I'm not sure. I wasn't aware of that restriction. I know from an SRE point of view, the flexibility of expanding volumes out of the box is appealing, but I'm not sure of drawbacks. There's also an aos-devel thread about this.

@cblecker

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

To update, SRE is discussing this internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.