Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1867735: Fix syncing of Manila CA certificate #75

Merged
merged 1 commit into from Aug 17, 2020
Merged

Bug 1867735: Fix syncing of Manila CA certificate #75

merged 1 commit into from Aug 17, 2020

Conversation

jsafrane
Copy link
Contributor

The sync failed, because CSO's KubeInformersForNamespaces did not watch openshift-config namespace.

Add the namespace to the namespace list + make sure that CSO panics on similar errors in future.

@jsafrane
Fix syncing of Manila CA certificate
4e22db7 
The sync failed, because CSO's KubeInformersForNamespaces did not watch
openshift-config namespace.

Add the namespace to the namespace list + make sure that CSO panics on
similar errors in future.
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 13, 2020
@openshift-ci-robot
Copy link
Contributor

@jsafrane: This pull request references Bugzilla bug 1867735, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1867735: Fix syncing of Manila CA certificate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 13, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2020
@jsafrane
Copy link
Contributor Author

/test e2e-openstack

@jsafrane
Copy link
Contributor Author

I can see storage is Available: true in the openstack CI job.
/retest

tsmetana
tsmetana approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@tsmetana tsmetana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2020
bertinatto
bertinatto reviewed Aug 13, 2020
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane, tsmetana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bertinatto,jsafrane,tsmetana]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jsafrane
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 7c688c4 into openshift:master Aug 17, 2020
@openshift-ci-robot
Copy link
Contributor

@jsafrane: All pull requests linked via external trackers have merged: openshift/csi-driver-manila-operator#49, openshift/cluster-storage-operator#75, openshift/cluster-storage-operator#74. Bugzilla bug 1867735 has been moved to the MODIFIED state.

In response to this:

Bug 1867735: Fix syncing of Manila CA certificate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@tsmetana tsmetana tsmetana approved these changes

@huffmanca huffmanca Awaiting requested review from huffmanca

Assignees

@bertinatto bertinatto

@tsmetana tsmetana

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jsafrane @openshift-ci-robot @openshift-bot @bertinatto @tsmetana @openshift-merge-robot