Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiext: wait for CRD using v1beta1 for compatibility on upgrades #265

Merged

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Oct 24, 2019

This is softening 4ee7b07 (#259) to use the older v1beta1 API version for waiting for CRDs to be established. This fixes the creation of v1beta1 CRDs before kube-apiserver is updated during a 4.2->4.3 update.

Note: this will not fix the creation of v1 CRDs before kube-apiserver is upgraded. Hence, we are still restricted in the use of v1 CRDs for early manifests.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2019
@wking
Copy link
Member

wking commented Oct 24, 2019

Context:

This is softening 4ee7b07 (#259) to support the older v1beta1 types because 4.2->4.3 upgrades will load the 4.3 cluster-version operator before loading the 4.3 OpenShift API server. The 4.2 OpenShift API server doesn't support the v1 types, so the 4.3 CVO chokes and dies (example link?). With this PR, the 4.3 CVO will use the v1beta1 types that both 4.2 and 4.3 OpenShift API servers understand.

Or something like that?

This is softening 4ee7b07 (openshift#259) to use the older v1beta1 API version
for waiting for CRDs to be established. This fixes the creation of
v1beta1 CRDs before kube-apiserver is updated during a 4.2->4.3
update.

Note: this will not fix the creation of v1 CRDs before kube-apiserver is
upgraded. Hence, we are still restricted in the use of v1 CRDs
for early manifests.
@wking
Copy link
Member

wking commented Oct 24, 2019

Looks good to me. Not sure if there's a way we can talk Prow into running 4.2->PR-tip CI on this...

@wking
Copy link
Member

wking commented Oct 24, 2019

All green. I guess we'll just see about 4.2->4.3 once this gets built into the 4.3 images ;).

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2019
@openshift-merge-robot openshift-merge-robot merged commit cd332aa into openshift:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants